Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 546733003: MIPS: To aid vector-based load ic work, we need to be able to handle the megamorphic load case in h… (Closed)

Created:
6 years, 3 months ago by balazs.kilvady
Modified:
6 years, 3 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: To aid vector-based load ic work, we need to be able to handle the megamorphic load case in hydrogen. Port r23772 (d6d07c5) Original commit message: Encapsulate megamorphic load/tail-call in hydrogen. A simple approach is to wrap the probe activity in a hydrogen instruction. The instruction is novel in that it always tail-calls away. BUG= R=paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=23781

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -58 lines) Patch
M src/ic/mips/ic-mips.cc View 2 chunks +2 lines, -20 lines 0 comments Download
M src/ic/mips/stub-cache-mips.cc View 5 chunks +11 lines, -9 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 2 chunks +2 lines, -20 lines 0 comments Download
M src/ic/mips64/stub-cache-mips64.cc View 5 chunks +11 lines, -9 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 2 chunks +29 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +22 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 2 chunks +29 lines, -0 lines 0 comments Download
M src/mips64/lithium-mips64.h View 2 chunks +22 lines, -0 lines 0 comments Download
M src/mips64/lithium-mips64.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
balazs.kilvady
6 years, 3 months ago (2014-09-08 16:18:41 UTC) #2
paul.l...
LGTM.
6 years, 3 months ago (2014-09-08 16:34:51 UTC) #3
balazs.kilvady
6 years, 3 months ago (2014-09-08 17:21:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23781 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698