Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 546713004: Revert of Move some scroll invalidations to the paint invalidation phase (Closed)

Created:
6 years, 3 months ago by kouhei (in TOK)
Modified:
6 years, 3 months ago
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Revert of Move some scroll invalidations to the paint invalidation phase (patchset #4 id:60001 of https://codereview.chromium.org/498773007/) Reason for revert: The patch is likely the culprit for Mac IMAGE failures. Example: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT%20Blink&tests=compositing%2Freflections%2Fsimple-composited-reflections.html&testType=layout-tests&showChrome=true Original issue's description: > Move some scroll invalidations to the paint invalidation phase > > Scrolling used to generate immediate invalidations that are now > postponed to the paint invalidation phase. In order to make this > works, scrolling updates needs to to happen before paint > invalidations. > > The test changes are either neutral (same amount of invalidations, > except that we generate them one at a time) or > compositing/repaint/fixed-pos-inside-composited-intermediate-layer > is a progression. > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181475 TBR=abarth@chromium.org,dsinclair@chromium.org,esprehn@chromium.org,leviw@chromium.org,vollick@chromium.org,wangxianzhu@chromium.orgm,jchaffraix@chromium.org NOTREECHECKS=true NOTRY=true

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -33 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-inside-composited-intermediate-layer-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-with-abs-pos-child-scroll-expected.txt View 1 chunk +2 lines, -4 lines 0 comments Download
M LayoutTests/compositing/repaint/fixed-pos-with-composited-child-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/fast/repaint/fixed-scroll-simple-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/platform/linux/fast/layers/scroll-descendant-with-cached-cliprects-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 7 chunks +68 lines, -20 lines 0 comments Download
M Source/core/rendering/RenderLayerRepainter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderLayerRepainter.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/platform/scroll/ScrollView.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
kouhei (in TOK)
Created Revert of Move some scroll invalidations to the paint invalidation phase
6 years, 3 months ago (2014-09-05 22:47:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kouhei@chromium.org/546713004/1
6 years, 3 months ago (2014-09-05 22:47:51 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 22:48:01 UTC) #4
Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 1322.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
5481ffceda7c20ac362c8d125c0d114fef0759ef..eed4d7f0c5321aa415358dd78a840b4abd1aaf5c
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -1322,8 +1322,6 @@
 crbug.com/409534
compositing/overflow/do-not-crash-use-after-free-update-widget-positions.html [
Failure Pass ]
 crbug.com/409534
virtual/gpu/compositedscrolling/overflow/do-not-crash-use-after-free-update-widget-positions.html
[ Failure Pass ]
 
-Bug(jchaffraix) fast/layers/scroll-descendant-with-cached-cliprects.html [
NeedsRebaseline ]
-
 crbug.com/401902  [ Win7 Debug ]
virtual/gpu/fast/canvas/canvas-lose-restore-googol-size.html [ Pass Failure ]
 
 crbug.com/402379 [ Win7 Debug ] storage/indexeddb/cursor-continue-validity.html
[ Pass Slow ]

Powered by Google App Engine
This is Rietveld 408576698