Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(47)

Issue 546703003: Editing: Let Selection.collapse with null clears selection. (Closed)

Created:
5 years, 2 months ago by yoichio
Modified:
5 years, 2 months ago
Reviewers:
yosin_UTC9, ojan
CC:
arv+blink, blink-reviews, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Editing: Let Selection.collapse with null clears selection. The current spec says Selection.collapse(null) raises exception and the implementation follows. However, many web apps assume that chrome clears selection when Selection.collapse(null) calls. Thus we revert the behavior. BUG=395318 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181487

Patch Set 1 : add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
A LayoutTests/editing/selection/collapse-null.html View 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/editing/selection/collapse-null-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
M Source/core/editing/DOMSelection.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M Source/core/editing/Selection.idl View 2 chunks +2 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
yoichio
5 years, 2 months ago (2014-09-05 07:13:09 UTC) #4
yosin_UTC9
LGTM Thanks for follow up!
5 years, 2 months ago (2014-09-05 08:06:59 UTC) #5
ojan
lgtm
5 years, 2 months ago (2014-09-05 17:17:25 UTC) #7
ojan
Thanks! Can you also email public-webapps and suggest that the spec be changed?
5 years, 2 months ago (2014-09-05 17:17:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoichio@chromium.org/546703003/40001
5 years, 2 months ago (2014-09-05 17:17:56 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2014-09-05 23:26:16 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as 181487

Powered by Google App Engine
This is Rietveld 408576698