Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: chrome/browser/browsing_data/browsing_data_file_system_helper.h

Issue 546663003: Remove Clone() from CannedBrowsingData*Helper classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browsing_data/browsing_data_file_system_helper.h
diff --git a/chrome/browser/browsing_data/browsing_data_file_system_helper.h b/chrome/browser/browsing_data/browsing_data_file_system_helper.h
index 21a23afc33a8673e9586dbf2b1141569f3a878f4..1735656ecbf2d1fa6ea754ce4dd844184a48253b 100644
--- a/chrome/browser/browsing_data/browsing_data_file_system_helper.h
+++ b/chrome/browser/browsing_data/browsing_data_file_system_helper.h
@@ -97,16 +97,6 @@ class CannedBrowsingDataFileSystemHelper
// we're writing to, so we'll accept it, but not store it.
explicit CannedBrowsingDataFileSystemHelper(Profile* profile);
- // Creates a copy of the file system helper. StartFetching can only respond
- // to one client at a time; we need to be able to act on multiple parallel
- // requests in certain situations (see CookiesTreeModel and its clients). For
- // these cases, simply clone the object and fire off another fetching process.
- //
- // Clone() is safe to call while StartFetching() is running. Clients of the
- // newly created object must themselves execute StartFetching(), however: the
- // copy will not have a pending fetch.
- CannedBrowsingDataFileSystemHelper* Clone();
-
// Manually adds a filesystem to the set of canned file systems that this
// helper returns via StartFetching. If an origin contains both a temporary
// and a persistent filesystem, AddFileSystem must be called twice (once for
@@ -140,8 +130,6 @@ class CannedBrowsingDataFileSystemHelper
virtual void DeleteFileSystemOrigin(const GURL& origin) OVERRIDE {}
private:
- // Used by Clone() to create an object without a Profile
- CannedBrowsingDataFileSystemHelper();
virtual ~CannedBrowsingDataFileSystemHelper();
// Holds the current list of filesystems returned to the client.

Powered by Google App Engine
This is Rietveld 408576698