Issue 546573002: Implement (and test) ProcessReader::Modules()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 546573002: Implement (and test) ProcessReader::Modules() (Closed)

Created:
6 years, 3 months ago by Mark Mentovai

Modified:
6 years, 3 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

Implement (and test) ProcessReader::Modules(). This depended on MachOImageReader, which recently landed, so it can now be added. TEST=util_test ProcessReader.*Modules R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/9dd0ac943a3827b5ae1595e6c24a833eedf01c93

Patch Set 2 : Fix 32-bit x86 #

Total comments: 1

Patch Set 3 : Address review feedback #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+335 lines, -13 lines)			Patch
M	util/mac/process_reader.h	View		2 chunks	+15 lines, -2 lines	0 comments	Download
M	util/mac/process_reader.cc	View	1 2	2 chunks	+115 lines, -5 lines	0 comments	Download
M	util/mac/process_reader_test.cc	View	1 2	7 chunks	+205 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Robert Sesek

LGTM https://codereview.chromium.org/546573002/diff/20001/util/mac/process_reader.cc File util/mac/process_reader.cc (right): https://codereview.chromium.org/546573002/diff/20001/util/mac/process_reader.cc#newcode399 util/mac/process_reader.cc:399: DCHECK_NE(all_image_infos.infoArray, 0u); Why not NULL instead of 0u?

6 years, 3 months ago (2014-09-05 17:14:58 UTC) #3

Mark Mentovai

6 years, 3 months ago (2014-09-05 17:43:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 9dd0ac9 (presubmit successful).