Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Unified Diff: util/mac/process_reader.h

Issue 546573002: Implement (and test) ProcessReader::Modules() (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | util/mac/process_reader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/mac/process_reader.h
diff --git a/util/mac/process_reader.h b/util/mac/process_reader.h
index 85f60adf3cb8629fa7a5287d99977fac57d782e4..56d9995485a0b54ca5d51de7050523d09ec57d91 100644
--- a/util/mac/process_reader.h
+++ b/util/mac/process_reader.h
@@ -69,8 +69,18 @@ struct ProcessReaderModule {
ProcessReaderModule();
~ProcessReaderModule();
+ //! \brief The pathname used to load the module from disk.
std::string name;
+
+ //! \brief The address where the base of the module is loaded in the remote
+ //! process.
mach_vm_address_t address;
+
+ //! \brief The module’s timestamp.
+ //!
+ //! This field will be `0` if its value cannot be determined. It can only be
+ //! determined for images that are loaded by dyld, so it will be `0` for the
+ //! main executable and for dyld itself.
time_t timestamp;
};
@@ -117,10 +127,13 @@ class ProcessReader {
//! \return Accesses the memory of the target task.
TaskMemory* Memory() { return task_memory_.get(); }
- //! \return The threads that are in the task (process).
+ //! \return The threads that are in the task (process). The first element (at
+ //! index `0`) corresponds to the main thread.
const std::vector<ProcessReaderThread>& Threads();
- //! \return The modules loaded in the process.
+ //! \return The modules loaded in the process. The first element (at index
+ //! `0`) corresponds to the main executable, and the final element
+ //! corresponds to the dynamic loader, dyld.
const std::vector<ProcessReaderModule>& Modules();
private:
« no previous file with comments | « no previous file | util/mac/process_reader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698