Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1379)

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 546523002: Improve error messaging with shared module import failures (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/webstore_installer.cc
diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc
index a378a494fc3029054aff03dddaa484392eb1a25a..454197c086222e504a1b29e1bcf696b31e7864ca 100644
--- a/chrome/browser/extensions/webstore_installer.cc
+++ b/chrome/browser/extensions/webstore_installer.cc
@@ -309,17 +309,11 @@ void WebstoreInstaller::Start() {
ExtensionService* extension_service =
ExtensionSystem::Get(profile_)->extension_service();
if (approval_.get() && approval_->dummy_extension.get()) {
- SharedModuleService::ImportStatus status =
- extension_service->shared_module_service()->CheckImports(
- approval_->dummy_extension.get(),
- &pending_modules_,
- &pending_modules_);
- // For this case, it is because some imports are not shared modules.
- if (status == SharedModuleService::IMPORT_STATUS_UNRECOVERABLE) {
- ReportFailure(kDependencyNotSharedModuleError,
- FAILURE_REASON_DEPENDENCY_NOT_SHARED_MODULE);
- return;
- }
+ extension_service->shared_module_service()->CheckImports(
+ approval_->dummy_extension.get(), &pending_modules_, &pending_modules_);
+ // Do not check the return value of CheckImports, the CRX installer
+ // will report appropriate error messages and fail to install if there
+ // is an import error.
}
// Add the extension main module into the list.
« no previous file with comments | « chrome/browser/extensions/crx_installer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698