Improve error messaging with shared module import failures

chrome/browser/extensions/webstore_installer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/webstore_installer.h"
 
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 291 matching lines @@
   AddRef();  // Balanced in ReportSuccess and ReportFailure.
 
   if (!crx_file::id_util::IdIsValid(id_)) {
     ReportFailure(kInvalidIdError, FAILURE_REASON_OTHER);
     return;
   }
 
   ExtensionService* extension_service =
     ExtensionSystem::Get(profile_)->extension_service();
   if (approval_.get() && approval_->dummy_extension.get()) {
-    SharedModuleService::ImportStatus status =
-        extension_service->shared_module_service()->CheckImports(
-            approval_->dummy_extension.get(),
-            &pending_modules_,
-            &pending_modules_);
-    // For this case, it is because some imports are not shared modules.
-    if (status == SharedModuleService::IMPORT_STATUS_UNRECOVERABLE) {
-      ReportFailure(kDependencyNotSharedModuleError,
-          FAILURE_REASON_DEPENDENCY_NOT_SHARED_MODULE);
-      return;
-    }
+    extension_service->shared_module_service()->CheckImports(
+        approval_->dummy_extension.get(), &pending_modules_, &pending_modules_);
+    // Do not check the return value of CheckImports, the CRX installer
+    // will report appropriate error messages and fail to install if there
+    // is an import error.
   }
 
   // Add the extension main module into the list.
   SharedModuleInfo::ImportInfo info;
   info.extension_id = id_;
   pending_modules_.push_back(info);
 
   total_modules_ = pending_modules_.size();
 
   std::set<std::string> ids;
@@ skipping 412 matching lines @@
         1,
         kMaxSizeKb,
         kNumBuckets);
   }
   UMA_HISTOGRAM_BOOLEAN(
       "Extensions.WebstoreDownload.InterruptTotalSizeUnknown",
       total_bytes <= 0);
 }
 
 }  // namespace extensions