Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 546523002: Improve error messaging with shared module import failures (Closed)

Created:
6 years, 3 months ago by elijahtaylor1
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Improve error messaging with shared module import failures BUG=410438 Committed: https://crrev.com/0befbe70d012f7679621ebfcaa981ac387aebe0f Cr-Commit-Position: refs/heads/master@{#293405}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/crx_installer.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/webstore_installer.cc View 1 chunk +5 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
elijahtaylor1
rockot: OWNERS erikkay (who does not do reviews): please review the messaging
6 years, 3 months ago (2014-09-04 19:28:39 UTC) #3
Ken Rockot(use gerrit already)
code lgtm
6 years, 3 months ago (2014-09-04 19:32:45 UTC) #4
elijahtaylor1
got offline message approval
6 years, 3 months ago (2014-09-04 21:06:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elijahtaylor@chromium.org/546523002/1
6 years, 3 months ago (2014-09-04 21:10:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9526efaf7e949340c715d369a849cb0d39bc9cb3
6 years, 3 months ago (2014-09-05 02:24:16 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:35:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0befbe70d012f7679621ebfcaa981ac387aebe0f
Cr-Commit-Position: refs/heads/master@{#293405}

Powered by Google App Engine
This is Rietveld 408576698