Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 546413002: Remove the warning for converting entries to URLs. (Closed)

Created:
6 years, 3 months ago by fukino
Modified:
6 years, 3 months ago
Reviewers:
mtomasz
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove the warning for converting entries to URLs. - Removed the warning for the call of util.entriesToURLs. - Made sure that all private-API call using entriesToURLs have TODO comments. - Added issue ID for the TODO comments. BUG=411790 TEST=manually confirmed Committed: https://crrev.com/c47cc4cb03c73513c2588d8086a0cda2346a93ce Cr-Commit-Position: refs/heads/master@{#293704}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M ui/file_manager/file_manager/background/js/file_operation_manager.js View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/common/js/util.js View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_tasks.js View 5 chunks +9 lines, -4 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_transfer_controller.js View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/metadata/metadata_cache.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
fukino
@mtomasz, could you take a look? Thanks!
6 years, 3 months ago (2014-09-08 09:15:06 UTC) #2
mtomasz
lgtm
6 years, 3 months ago (2014-09-08 09:26:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/546413002/1
6 years, 3 months ago (2014-09-08 09:27:59 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-08 11:28:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/546413002/1
6 years, 3 months ago (2014-09-08 11:30:18 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9c9f019a00dd78fcf1ae8a7c2cfc9c558e4bb4e2
6 years, 3 months ago (2014-09-08 11:42:59 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c47cc4cb03c73513c2588d8086a0cda2346a93ce
Cr-Commit-Position: refs/heads/master@{#293704}

Powered by Google App Engine
This is Rietveld 408576698