ui/file_manager/file_manager/background/js/file_operation_manager.js - Issue 546413002: Remove the warning for converting entries to URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/background/js/file_operation_manager.js

Issue 546413002: Remove the warning for converting entries to URLs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/file_manager/file_manager/background/js/file_operation_manager.js

diff --git a/ui/file_manager/file_manager/background/js/file_operation_manager.js b/ui/file_manager/file_manager/background/js/file_operation_manager.js

index ad6ccc28e6f60d25869249915566c597c0413ed7..516f9cf4c5ba2c82bbc5f5284a7442938e66085f 100644

--- a/ui/file_manager/file_manager/background/js/file_operation_manager.js

+++ b/ui/file_manager/file_manager/background/js/file_operation_manager.js

@@ -341,8 +341,8 @@ fileOperationUtil.copyTo = function(

fileOperationUtil.zipSelection = function(

sources, parent, newName, successCallback, errorCallback) {

- // TODO(mtomasz): Pass Entries instead of URLs. Entries can be converted to

- // URLs in custom bindings.

+ // TODO(mtomasz): Move conversion from entry to url to custom bindings.

+ // crbug.com/345527.

chrome.fileBrowserPrivate.zipSelection(

parent.toURL(),

util.entriesToURLs(sources),

« no previous file with comments | « no previous file | ui/file_manager/file_manager/common/js/util.js » ('j') | no next file with comments »