ServiceWorker: Change worker script fetch error code(1/3).

ServiceWorker: Change worker script fetch error code.

Change worker script fetch error code in "Update" algorithm to align
with spec:
Non 2xx response will be rejected with NetworkError;
Redirected response will be rejected with SecurityError;
Reponse with Wrong MIME type will be rejected with SecurityError.

(1/3): this.
(2/3): https://codereview.chromium.org/567903002/
(3/3): Layout test & Blink side cleanup

BUG=408421
TEST=http/tests/serviceworker

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182381

[xiang, 2014-09-12 05:07:37]

xiang.long@intel.com changed reviewers:
+ michaeln@chromium.org, nhiroki@chromium.org

[xiang, 2014-09-12 05:08:06]

PTAL, thanks!

[nhiroki, 2014-09-12 07:57:29]

https://codereview.chromium.org/546353003/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/registration.html (right):

https://codereview.chromium.org/546353003/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/registration.html:111:
assert_equals(reason.name, 'AbortError',
This 'AbortError' is ephemeral and will be replaced with 'SecurityError', is
this right? If so, how about adding this test in the 3rd patch?

https://codereview.chromium.org/546353003/diff/1/Source/modules/serviceworker...
File Source/modules/serviceworkers/ServiceWorkerError.cpp (right):

https://codereview.chromium.org/546353003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/ServiceWorkerError.cpp:51: return
DOMException::create(AbortError, "The Service Worker security policy prevented
an action.");
IIUC, you don't have to change this error type and "url-limits.html" if you
disable "registration.html" until your 3rd patch.

(I'd prefer to changing/disabling related tests(registration.html) rather than
non-related tests(url-limits.html) even if it's temporary.)

https://codereview.chromium.org/546353003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/ServiceWorkerError.cpp:61: return
DOMException::create(AbortError, "The Service Worker failed by network.");
ditto (you can pass "NetworkError" if disabling the test)

[xiang, 2014-09-16 05:47:41]

Thanks, would you take a look again?

https://codereview.chromium.org/546353003/diff/1/LayoutTests/http/tests/servi...
File LayoutTests/http/tests/serviceworker/registration.html (right):

https://codereview.chromium.org/546353003/diff/1/LayoutTests/http/tests/servi...
LayoutTests/http/tests/serviceworker/registration.html:111:
assert_equals(reason.name, 'AbortError',
On 2014/09/12 07:57:28, nhiroki wrote:
> This 'AbortError' is ephemeral and will be replaced with 'SecurityError', is
> this right? If so, how about adding this test in the 3rd patch?

Right, I will move it to 3rd patch.

https://codereview.chromium.org/546353003/diff/1/Source/modules/serviceworker...
File Source/modules/serviceworkers/ServiceWorkerError.cpp (right):

https://codereview.chromium.org/546353003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/ServiceWorkerError.cpp:51: return
DOMException::create(AbortError, "The Service Worker security policy prevented
an action.");
On 2014/09/12 07:57:28, nhiroki wrote:
> IIUC, you don't have to change this error type and "url-limits.html" if you
> disable "registration.html" until your 3rd patch.
> 
> (I'd prefer to changing/disabling related tests(registration.html) rather than
> non-related tests(url-limits.html) even if it's temporary.)

Done.

https://codereview.chromium.org/546353003/diff/1/Source/modules/serviceworker...
Source/modules/serviceworkers/ServiceWorkerError.cpp:61: return
DOMException::create(AbortError, "The Service Worker failed by network.");
On 2014/09/12 07:57:28, nhiroki wrote:
> ditto (you can pass "NetworkError" if disabling the test)

Done.

[nhiroki, 2014-09-16 06:56:48]

LGTM, thanks!

[xiang, 2014-09-22 01:18:09]

The CQ bit was checked by xiang.long@intel.com

[commit-bot: I haz the power, 2014-09-22 01:18:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/546353003/20001

[commit-bot: I haz the power, 2014-09-22 01:21:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-22 01:21:32]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/58805)

[xiang, 2014-09-22 01:24:45]

The CQ bit was checked by xiang.long@intel.com

[commit-bot: I haz the power, 2014-09-22 01:24:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/546353003/40001

[commit-bot: I haz the power, 2014-09-22 01:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-22 01:32:54]

Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

[xiang, 2014-09-22 01:37:21]

xiang.long@intel.com changed reviewers:
+ tkent@chromium.org

[xiang, 2014-09-22 01:39:29]

tkent@ Could you please review public/platform/WebServiceWorkerError.h? Thanks!

[tkent, 2014-09-22 02:14:19]

The CQ bit was checked by tkent@chromium.org

[tkent, 2014-09-22 02:14:20]

lgtm

[commit-bot: I haz the power, 2014-09-22 02:14:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/546353003/40001

[commit-bot: I haz the power, 2014-09-22 02:30:11]

Committed patchset #3 (id:40001) as 182381