LayoutTests/http/tests/serviceworker/registration.html - Issue 546353003: ServiceWorker: Change worker script fetch error code(1/3).

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/http/tests/serviceworker/registration.html

Issue 546353003: ServiceWorker: Change worker script fetch error code(1/3). (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/http/tests/serviceworker/chromium/url-limits.html ('k') | Source/modules/serviceworkers/ServiceWorkerError.cpp » ('j') | Source/modules/serviceworkers/ServiceWorkerError.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <title>Service Worker: Registration</title>	2 <title>Service Worker: Registration</title>

3 <script src="../resources/testharness.js"></script>	3 <script src="../resources/testharness.js"></script>

4 <script src="../resources/testharnessreport.js"></script>	4 <script src="../resources/testharnessreport.js"></script>

5 <script src="resources/test-helpers.js"></script>	5 <script src="resources/test-helpers.js"></script>

6 <script>	6 <script>

7 (function() {	7 (function() {

8 var t = async_test('Registering normal pattern');	8 var t = async_test('Registering normal pattern');

9 t.step(function() {	9 t.step(function() {

10 var scope = '/registration/';	10 var scope = '/registration/';

(...skipping 79 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
90 }),	90 }),

91 t.step_func(function(reason) {	91 t.step_func(function(reason) {

92 assert_equals(reason.name, 'AbortError',	92 assert_equals(reason.name, 'AbortError',

93 'Registration of plain text script should fail.');	93 'Registration of plain text script should fail.');

94 t.done();	94 t.done();

95 })	95 })

96 );	96 );

97 });	97 });

98 }());	98 }());

99	99

	100 (function() {

	101 var t = async_test('Registering redirected script');

	102 t.step(function() {

	103 navigator.serviceWorker.register(

	104 'resources/redirect.php?Redirect=' +

	105 encodeURIComponent('/resources/registration-worker.js')

	106 ).then(

	107 t.step_func(function(registration) {

	108 assert_unreached('Registration of redirected script should fail. ');

	109 }),

	110 t.step_func(function(reason) {

	111 assert_equals(reason.name, 'AbortError',
	nhiroki 2014/09/12 07:57:28 This 'AbortError' is ephemeral and will be replace This 'AbortError' is ephemeral and will be replaced with 'SecurityError', is this right? If so, how about adding this test in the 3rd patch? xiang 2014/09/16 05:47:41 Right, I will move it to 3rd patch. Show quoted text On 2014/09/12 07:57:28, nhiroki wrote: > This 'AbortError' is ephemeral and will be replaced with 'SecurityError', is > this right? If so, how about adding this test in the 3rd patch? Right, I will move it to 3rd patch.
	112 'Registration of redirected script should fail.');

	113 t.done();

	114 })

	115 );

	116 });

	117 }());

	118

100 </script>	119 </script>

OLD	NEW