[ServiceWorker] Introduce isControlledByServiceWorker() in FrameLoaderClient and WebFrameClient

[ServiceWorker] Introduce isControlledByServiceWorker() in FrameLoaderClient and WebFrameClient

We need to check this in DocumentThreadableLoader not to send CORS preflight requests to the ServiceWorker.

Chromium side is implemented in https://codereview.chromium.org/553603002/.


BUG=411151
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181549

[horo, 2014-09-08 04:59:29]

Patchset #1 (id:1) has been deleted

[horo, 2014-09-08 05:06:17]

horo@chromium.org changed reviewers:
+ nhiroki@chromium.org

[horo, 2014-09-08 05:06:18]

nhiroki@
Could you please review this?

[nhiroki, 2014-09-08 05:33:09]

lgtm

[horo, 2014-09-08 06:25:54]

horo@chromium.org changed reviewers:
+ tkent@chromium.org

[horo, 2014-09-08 06:25:54]

tkent@
Could you please review this?

[tkent, 2014-09-08 07:38:33]

https://codereview.chromium.org/546263002/diff/20001/Source/web/FrameLoaderCl...
File Source/web/FrameLoaderClientImpl.cpp (right):

https://codereview.chromium.org/546263002/diff/20001/Source/web/FrameLoaderCl...
Source/web/FrameLoaderClientImpl.cpp:816: return
m_webFrame->client()->controlledByServiceWorker();
nit:
    return m_webFrame->client() &&
m_webFrame->client()->controlledByServiceWorker();
is simpler.

https://codereview.chromium.org/546263002/diff/20001/public/web/WebFrameClient.h
File public/web/WebFrameClient.h (right):

https://codereview.chromium.org/546263002/diff/20001/public/web/WebFrameClien...
public/web/WebFrameClient.h:572: virtual bool controlledByServiceWorker() {
return false; }
The function name should be |isControlledByServiceWorker|.
See #5 of http://www.chromium.org/blink/coding-style#TOC-Names

[horo, 2014-09-08 08:19:42]

https://codereview.chromium.org/546263002/diff/20001/Source/web/FrameLoaderCl...
File Source/web/FrameLoaderClientImpl.cpp (right):

https://codereview.chromium.org/546263002/diff/20001/Source/web/FrameLoaderCl...
Source/web/FrameLoaderClientImpl.cpp:816: return
m_webFrame->client()->controlledByServiceWorker();
On 2014/09/08 07:38:33, tkent wrote:
> nit:
>     return m_webFrame->client() &&
> m_webFrame->client()->controlledByServiceWorker();
> is simpler.

Done.

https://codereview.chromium.org/546263002/diff/20001/public/web/WebFrameClient.h
File public/web/WebFrameClient.h (right):

https://codereview.chromium.org/546263002/diff/20001/public/web/WebFrameClien...
public/web/WebFrameClient.h:572: virtual bool controlledByServiceWorker() {
return false; }
On 2014/09/08 07:38:33, tkent wrote:
> The function name should be |isControlledByServiceWorker|.
> See #5 of http://www.chromium.org/blink/coding-style#TOC-Names

Done.

[tkent, 2014-09-08 08:23:28]

The CQ bit was checked by tkent@chromium.org

[tkent, 2014-09-08 08:23:29]

lgtm

[commit-bot: I haz the power, 2014-09-08 08:24:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/horo@chromium.org/546263002/40001

[commit-bot: I haz the power, 2014-09-08 09:26:36]

Committed patchset #2 (id:40001) as 181549

[horo, 2014-09-24 12:07:29]

Patchset #3 (id:60001) has been deleted