Fix the uses of T* conversion operator from scoped_refptr<T> which is now removed.

Fix the uses of T* conversion operator from scoped_refptr<T> which is now removed.

Please see https://codereview.chromium.org/510323002 for reference.

BUG=None

Committed: https://crrev.com/b2aa2ab01713358c4e0a22c7045a18a6f0d5a2a2
Cr-Commit-Position: refs/heads/master@{#293778}

[lcwu1, 2014-09-07 00:02:37]

lcwu@chromium.org changed reviewers:
+ damienv@chromium.org, gunsch@chromium.org

[gunsch, 2014-09-07 03:52:34]

On 2014/09/07 00:02:37, lcwu1 wrote:

lgtm

[lcwu1, 2014-09-08 15:11:41]

The CQ bit was checked by lcwu@chromium.org

[commit-bot: I haz the power, 2014-09-08 15:12:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lcwu@chromium.org/546243002/1

[commit-bot: I haz the power, 2014-09-08 15:12:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-08 15:12:19]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[damienv1, 2014-09-08 16:27:21]

https://codereview.chromium.org/546243002/diff/1/chromecast/common/chromecast...
File chromecast/common/chromecast_config.cc (right):

https://codereview.chromium.org/546243002/diff/1/chromecast/common/chromecast...
chromecast/common/chromecast_config.cc:86:
prefServiceFactory.SetUserPrefsFile(config_path_, task_runner.get());
Is it safe ?
Ref count for task runner will be decremented at the end of this function.

https://codereview.chromium.org/546243002/diff/1/chromecast/shell/browser/url...
File chromecast/shell/browser/url_request_context_factory.cc (right):

https://codereview.chromium.org/546243002/diff/1/chromecast/shell/browser/url...
chromecast/shell/browser/url_request_context_factory.cc:209:
content::BrowserThread::FILE).get()),
Why do you need raw pointers here ?
See prototype:
 static ProxyConfigService* CreateSystemProxyConfigService(
      const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner,
      const scoped_refptr<base::SingleThreadTaskRunner>& file_task_runner);

[lcwu1, 2014-09-08 18:01:58]

https://codereview.chromium.org/546243002/diff/1/chromecast/common/chromecast...
File chromecast/common/chromecast_config.cc (right):

https://codereview.chromium.org/546243002/diff/1/chromecast/common/chromecast...
chromecast/common/chromecast_config.cc:86:
prefServiceFactory.SetUserPrefsFile(config_path_, task_runner.get());
On 2014/09/08 16:27:21, damienv1 wrote:
> Is it safe ?
> Ref count for task runner will be decremented at the end of this function.

Yes, it is. task_runner's raw pointer gets passed into JsonPrefStore's
constructor, which in turn (through a temporary scoped_refptr) assigns it to a
scoped_refptr data member.

https://codereview.chromium.org/546243002/diff/1/chromecast/shell/browser/url...
File chromecast/shell/browser/url_request_context_factory.cc (right):

https://codereview.chromium.org/546243002/diff/1/chromecast/shell/browser/url...
chromecast/shell/browser/url_request_context_factory.cc:209:
content::BrowserThread::FILE).get()),
On 2014/09/08 16:27:21, damienv1 wrote:
> Why do you need raw pointers here ?
> See prototype:
>  static ProxyConfigService* CreateSystemProxyConfigService(
>       const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner,
>       const scoped_refptr<base::SingleThreadTaskRunner>& file_task_runner);

This is indeed a bug. Thanks for catching this. Done.

[damienv1, 2014-09-08 18:17:07]

lgtm

[lcwu1, 2014-09-08 18:31:11]

The CQ bit was checked by lcwu@chromium.org

[commit-bot: I haz the power, 2014-09-08 18:48:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lcwu@chromium.org/546243002/20001

[commit-bot: I haz the power, 2014-09-08 20:31:28]

Committed patchset #2 (id:20001) as 4ea82ba9e06ba3b4094e06117fefa24833f41974

[commit-bot: I haz the power, 2014-09-10 03:47:56]

Patchset 2 (id:??) landed as
https://crrev.com/b2aa2ab01713358c4e0a22c7045a18a6f0d5a2a2
Cr-Commit-Position: refs/heads/master@{#293778}