Fix the uses of T* conversion operator from scoped_refptr<T> which is now removed.

chromecast/shell/browser/url_request_context_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/shell/browser/url_request_context_factory.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/macros.h"
 #include "base/path_service.h"
@@ skipping 132 matching lines @@
   // Cast http user agent settings must be initialized in UI thread
   // because it registers itself to pref notification observer which is not
   // thread safe.
   http_user_agent_settings_.reset(new CastHttpUserAgentSettings());
 }
 
 net::URLRequestContextGetter* URLRequestContextFactory::CreateMainGetter(
     content::BrowserContext* browser_context,
     content::ProtocolHandlerMap* protocol_handlers,
     content::URLRequestInterceptorScopedVector request_interceptors) {
-  DCHECK(!main_getter_) << "Main URLRequestContextGetter already initialized";
+  DCHECK(!main_getter_.get())
+      << "Main URLRequestContextGetter already initialized";
   main_getter_ = new MainURLRequestContextGetter(this,
                                                  browser_context,
                                                  protocol_handlers,
                                                  request_interceptors.Pass());
   return main_getter_.get();
 }
 
 net::URLRequestContextGetter* URLRequestContextFactory::GetMainGetter() {
-  CHECK(main_getter_);
+  CHECK(main_getter_.get());
   return main_getter_.get();
 }
 
 net::URLRequestContextGetter* URLRequestContextFactory::GetSystemGetter() {
-  if (!system_getter_) {
+  if (!system_getter_.get()) {
     system_getter_ = new URLRequestContextGetter(this, false);
   }
   return system_getter_.get();
 }
 
 net::URLRequestContextGetter* URLRequestContextFactory::GetMediaGetter() {
-  if (!media_getter_) {
+  if (!media_getter_.get()) {
     media_getter_ = new URLRequestContextGetter(this, true);
   }
   return media_getter_.get();
 }
 
 void URLRequestContextFactory::InitializeSystemContextDependencies() {
   if (system_dependencies_initialized_)
     return;
 
   host_resolver_ = net::HostResolver::CreateDefaultResolver(NULL);
@@ skipping 12 matching lines @@
   transport_security_state_.reset(new net::TransportSecurityState());
   http_auth_handler_factory_.reset(
       net::HttpAuthHandlerFactory::CreateDefault(host_resolver_.get()));
 
   http_server_properties_.reset(new net::HttpServerPropertiesImpl);
 
   proxy_service_.reset(net::ProxyService::CreateUsingSystemProxyResolver(
       net::ProxyService::CreateSystemProxyConfigService(
           content::BrowserThread::GetMessageLoopProxyForThread(
               content::BrowserThread::IO).get(),
-          content::BrowserThread::UnsafeGetMessageLoopForThread(
-              content::BrowserThread::FILE)),
+          content::BrowserThread::GetMessageLoopProxyForThread(
+              content::BrowserThread::FILE).get()),

[damienv1, 2014/09/08 16:27:21]

Why do you need raw pointers here ?
See prototype:
 static ProxyConfigService* CreateSystemProxyConfigService(
      const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner,
      const scoped_refptr<base::SingleThreadTaskRunner>& file_task_runner);

[lcwu1, 2014/09/08 18:01:58]

This is indeed a bug. Thanks for catching this. Done.

       0,
       NULL));
   system_dependencies_initialized_ = true;
 }
 
 void URLRequestContextFactory::InitializeMainContextDependencies(
     net::HttpTransactionFactory* transaction_factory,
     content::ProtocolHandlerMap* protocol_handlers,
     content::URLRequestInterceptorScopedVector request_interceptors) {
   if (main_dependencies_initialized_)
@@ skipping 86 matching lines @@
       system_transaction_factory_.get());
   system_context->set_http_user_agent_settings(
       http_user_agent_settings_.get());
   system_context->set_cookie_store(
       content::CreateCookieStore(content::CookieStoreConfig()));
   return system_context;
 }
 
 net::URLRequestContext* URLRequestContextFactory::CreateMediaRequestContext() {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
-  DCHECK(main_getter_)
+  DCHECK(main_getter_.get())
       << "Getting MediaRequestContext before MainRequestContext";
   net::URLRequestContext* main_context = main_getter_->GetURLRequestContext();
 
   // Set non caching backend.
   net::HttpNetworkSession* main_session =
       main_transaction_factory_->GetSession();
   InitializeMediaContextDependencies(
       new net::HttpNetworkLayer(main_session));
 
   net::URLRequestContext* media_context = new net::URLRequestContext();
@@ skipping 51 matching lines @@
       http_user_agent_settings_.get());
 
   main_context->set_http_transaction_factory(
       main_transaction_factory_.get());
   main_context->set_job_factory(main_job_factory_.get());
   return main_context;
 }
 
 }  // namespace shell
 }  // namespace chromecast