net: allow invalid TransportSecurityState to process invalid DNS names.

net: allow invalid TransportSecurityState to process invalid DNS names.

Other parts of the network stack are processing and fetching results from
invalid DNS names, but TransportSecurityState was rejecting them and therefore
HSTS policies didn't apply.

This change removes the sanity checking so that TransportSecurityState is more
promiscuous in what it'll try and process.

BUG=312689
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232463

[Ryan Sleevi, 2013-10-31 17:34:25]

lgtm

[palmer, 2013-10-31 17:46:32]

LGTM to me too. But maybe we should make the sanity check happen throughout the
net stack someday?

[agl, 2013-10-31 19:11:47]

On Thu, Oct 31, 2013 at 1:46 PM,  <palmer@chromium.org> wrote:
> LGTM to me too. But maybe we should make the sanity check happen throughout
> the
> net stack someday?

If we haven't been doing it so far, then I'm sure that there's people
depending on the bad names now :(


Cheers

AGL

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ryan Sleevi, 2013-10-31 19:15:42]

I'm fine with breaking bad names.

M33, anyone? :)


On Thu, Oct 31, 2013 at 12:11 PM, Adam Langley <agl@chromium.org> wrote:

> On Thu, Oct 31, 2013 at 1:46 PM,  <palmer@chromium.org> wrote:
> > LGTM to me too. But maybe we should make the sanity check happen
> throughout
> > the
> > net stack someday?
>
> If we haven't been doing it so far, then I'm sure that there's people
> depending on the bad names now :(
>
>
> Cheers
>
> AGL
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-10-31 20:02:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/54623005/1

[commit-bot: I haz the power, 2013-10-31 23:51:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/54623005/1

[commit-bot: I haz the power, 2013-11-01 03:01:06]

Retried try job too often on linux_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2013-11-01 16:22:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/54623005/570001

[commit-bot: I haz the power, 2013-11-01 17:48:24]

Retried try job too often on linux_chromeos for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-11-01 18:01:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/54623005/570001

[cbentzel, 2013-11-01 18:38:59]

Sure. Let's just get some UMA to see the frequency.

On Thu, Oct 31, 2013 at 3:15 PM, Ryan Sleevi <rsleevi@chromium.org> wrote:
> I'm fine with breaking bad names.
>
> M33, anyone? :)
>
>
> On Thu, Oct 31, 2013 at 12:11 PM, Adam Langley <agl@chromium.org> wrote:
>>
>> On Thu, Oct 31, 2013 at 1:46 PM,  <palmer@chromium.org> wrote:
>> > LGTM to me too. But maybe we should make the sanity check happen
>> > throughout
>> > the
>> > net stack someday?
>>
>> If we haven't been doing it so far, then I'm sure that there's people
>> depending on the bad names now :(
>>
>>
>> Cheers
>>
>> AGL
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[cbentzel, 2013-11-01 19:41:28]

On 2013/11/01 18:38:59, cbentzel wrote:
> Sure. Let's just get some UMA to see the frequency.

And LGTM in case I broke presubmits with a peanut gallery comment.

> 
> On Thu, Oct 31, 2013 at 3:15 PM, Ryan Sleevi <mailto:rsleevi@chromium.org>
wrote:
> > I'm fine with breaking bad names.
> >
> > M33, anyone? :)
> >
> >
> > On Thu, Oct 31, 2013 at 12:11 PM, Adam Langley <mailto:agl@chromium.org>
wrote:
> >>
> >> On Thu, Oct 31, 2013 at 1:46 PM,  <mailto:palmer@chromium.org> wrote:
> >> > LGTM to me too. But maybe we should make the sanity check happen
> >> > throughout
> >> > the
> >> > net stack someday?
> >>
> >> If we haven't been doing it so far, then I'm sure that there's people
> >> depending on the bad names now :(
> >>
> >>
> >> Cheers
> >>
> >> AGL
> >
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[cbentzel, 2013-11-01 19:41:30]

On 2013/11/01 18:38:59, cbentzel wrote:
> Sure. Let's just get some UMA to see the frequency.

And LGTM in case I broke presubmits with a peanut gallery comment.

> 
> On Thu, Oct 31, 2013 at 3:15 PM, Ryan Sleevi <mailto:rsleevi@chromium.org>
wrote:
> > I'm fine with breaking bad names.
> >
> > M33, anyone? :)
> >
> >
> > On Thu, Oct 31, 2013 at 12:11 PM, Adam Langley <mailto:agl@chromium.org>
wrote:
> >>
> >> On Thu, Oct 31, 2013 at 1:46 PM,  <mailto:palmer@chromium.org> wrote:
> >> > LGTM to me too. But maybe we should make the sanity check happen
> >> > throughout
> >> > the
> >> > net stack someday?
> >>
> >> If we haven't been doing it so far, then I'm sure that there's people
> >> depending on the bad names now :(
> >>
> >>
> >> Cheers
> >>
> >> AGL
> >
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2013-11-01 19:45:37]

Retried try job too often on linux_chromeos for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-11-01 20:01:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/agl@chromium.org/54623005/570001

[commit-bot: I haz the power, 2013-11-01 20:40:00]

Change committed as 232463