net/base/dns_util_unittest.cc - Issue 54623005: net: allow invalid TransportSecurityState to process invalid DNS names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/dns_util_unittest.cc

Issue 54623005: net: allow invalid TransportSecurityState to process invalid DNS names. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix browser tests. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/dns_util_unittest.cc

diff --git a/net/base/dns_util_unittest.cc b/net/base/dns_util_unittest.cc

index 1e1e4f0381178439afb488bdd05eec2466709a38..d91753f4f736a5e64130711eff518462cdbde4c1 100644

--- a/net/base/dns_util_unittest.cc

+++ b/net/base/dns_util_unittest.cc

@@ -70,17 +70,4 @@ TEST_F(DNSUtilTest, DNSDomainToString) {

EXPECT_EQ("", DNSDomainToString("\x06"));

}

-TEST_F(DNSUtilTest, STD3ASCII) {

- EXPECT_TRUE(IsSTD3ASCIIValidCharacter('a'));

- EXPECT_TRUE(IsSTD3ASCIIValidCharacter('b'));

- EXPECT_TRUE(IsSTD3ASCIIValidCharacter('c'));

- EXPECT_TRUE(IsSTD3ASCIIValidCharacter('1'));

- EXPECT_TRUE(IsSTD3ASCIIValidCharacter('2'));

- EXPECT_TRUE(IsSTD3ASCIIValidCharacter('3'));

- EXPECT_FALSE(IsSTD3ASCIIValidCharacter('.'));

- EXPECT_FALSE(IsSTD3ASCIIValidCharacter('/'));

- EXPECT_FALSE(IsSTD3ASCIIValidCharacter('\x00'));

} // namespace net

« no previous file with comments | « net/base/dns_util.cc ('k') | net/http/transport_security_state.cc » ('j') | no next file with comments »