Android WebView: clean up the AwContentsClientBridge webcontents userdata.

When we destroy the AwContentsClientBridge, clear the pointer to it held by webcontents user data.

Also ensure that if we don't post the callback to the java side to run the js dialog callback in the embedding app that we run the callback.

BUG=411399
Committed: https://crrev.com/ad2403bd4cae2c2764097addf2caa9dfc44e9b10
Cr-Commit-Position: refs/heads/master@{#293642}

[benm (inactive), 2014-09-05 17:34:40]

benm@chromium.org changed reviewers:
+ boliu@chromium.org

[benm (inactive), 2014-09-05 17:34:40]

will fix up commit message soon, but I think your analysis is sound Bo (and
found another place we could mess up I think). Haven't been able to repro the
original issue to verify 100%, though.

[boliu, 2014-09-05 17:40:53]

Write a better description pls

What other place did you find?

https://codereview.chromium.org/545963002/diff/1/android_webview/browser/aw_c...
File android_webview/browser/aw_contents_client_bridge_base.cc (right):

https://codereview.chromium.org/545963002/diff/1/android_webview/browser/aw_c...
android_webview/browser/aw_contents_client_bridge_base.cc:73:
AwContentsClientBridgeBase::~AwContentsClientBridgeBase() {
Does it make sense to call RemoveUerData here rather than adding Disassociate?

[benm (inactive), 2014-09-05 17:44:23]

On 5 September 2014 18:40, <boliu@chromium.org> wrote:

> Write a better description pls
>

As I said, coming soon with a bug :-) Just heading out for the day so
didn't get round to it yet.


>
> What other place did you find?
>

Where we check the java ref in aw_contents we were returning without
running the callback.


>
>
> https://codereview.chromium.org/545963002/diff/1/android_
> webview/browser/aw_contents_client_bridge_base.cc
> File android_webview/browser/aw_contents_client_bridge_base.cc (right):
>
> https://codereview.chromium.org/545963002/diff/1/android_
> webview/browser/aw_contents_client_bridge_base.cc#newcode73
> android_webview/browser/aw_contents_client_bridge_base.cc:73:
> AwContentsClientBridgeBase::~AwContentsClientBridgeBase() {
> Does it make sense to call RemoveUerData here rather than adding
> Disassociate?
>

Well, we don't have web_contents here, and the symmetry of associate and
disassociate seemed nice.


>
> https://codereview.chromium.org/545963002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[boliu, 2014-09-05 17:46:25]

lgtm % better message and bug

[benm (inactive), 2014-09-05 18:42:37]

thanks bo, commit message updated & bug filed (I ended up staying here longer
...)

[benm (inactive), 2014-09-05 19:16:30]

The CQ bit was checked by benm@chromium.org

[commit-bot: I haz the power, 2014-09-05 19:16:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/benm@chromium.org/545963002/1

[commit-bot: I haz the power, 2014-09-06 01:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-06 01:20:37]

Exceeded time limit waiting for builds to trigger.

[boliu, 2014-09-06 06:32:54]

The CQ bit was checked by boliu@chromium.org

[commit-bot: I haz the power, 2014-09-06 06:34:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/benm@chromium.org/545963002/1

[benm (inactive), 2014-09-06 08:22:23]

The CQ bit was unchecked by benm@chromium.org

[benm (inactive), 2014-09-06 10:28:16]

The CQ bit was checked by benm@chromium.org

[commit-bot: I haz the power, 2014-09-06 10:29:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/benm@chromium.org/545963002/20001

[commit-bot: I haz the power, 2014-09-06 13:51:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-06 13:51:33]

Exceeded time limit waiting for builds to trigger.

[benm (inactive), 2014-09-06 13:57:32]

The CQ bit was checked by benm@chromium.org

[commit-bot: I haz the power, 2014-09-06 13:57:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/benm@chromium.org/545963002/20001

[commit-bot: I haz the power, 2014-09-06 15:58:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-06 15:58:20]

Exceeded time limit waiting for builds to trigger.

[benm (inactive), 2014-09-07 00:04:13]

The CQ bit was checked by benm@chromium.org

[commit-bot: I haz the power, 2014-09-07 00:04:39]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/benm@chromium.org/545963002/20001

[commit-bot: I haz the power, 2014-09-07 00:05:55]

Committed patchset #2 (id:20001) as bafb7ef3239ed1db29393ca1d528af08a2f19dfb

[commit-bot: I haz the power, 2014-09-10 03:43:35]

Patchset 2 (id:??) landed as
https://crrev.com/ad2403bd4cae2c2764097addf2caa9dfc44e9b10
Cr-Commit-Position: refs/heads/master@{#293642}