Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: android_webview/browser/aw_contents_client_bridge_base.h

Issue 545963002: Android WebView: clean up the AwContentsClientBridge webcontents userdata. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add another missing callback run Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | android_webview/browser/aw_contents_client_bridge_base.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_BROWSER_AW_CONTENTS_CLIENT_BRIDGE_BASE_H_ 5 #ifndef ANDROID_WEBVIEW_BROWSER_AW_CONTENTS_CLIENT_BRIDGE_BASE_H_
6 #define ANDROID_WEBVIEW_BROWSER_AW_CONTENTS_CLIENT_BRIDGE_BASE_H_ 6 #define ANDROID_WEBVIEW_BROWSER_AW_CONTENTS_CLIENT_BRIDGE_BASE_H_
7 7
8 #include "base/callback_forward.h" 8 #include "base/callback_forward.h"
9 #include "base/supports_user_data.h" 9 #include "base/supports_user_data.h"
10 #include "content/public/browser/javascript_dialog_manager.h" 10 #include "content/public/browser/javascript_dialog_manager.h"
(...skipping 16 matching lines...) Expand all
27 // implementor of the base class plumbs the request to the Java side and 27 // implementor of the base class plumbs the request to the Java side and
28 // eventually to the webviewclient. This layering hides the details of 28 // eventually to the webviewclient. This layering hides the details of
29 // native/ from browser/ layer. 29 // native/ from browser/ layer.
30 class AwContentsClientBridgeBase { 30 class AwContentsClientBridgeBase {
31 public: 31 public:
32 typedef base::Callback<void(net::X509Certificate*)> SelectCertificateCallback; 32 typedef base::Callback<void(net::X509Certificate*)> SelectCertificateCallback;
33 33
34 // Adds the handler to the UserData registry. 34 // Adds the handler to the UserData registry.
35 static void Associate(content::WebContents* web_contents, 35 static void Associate(content::WebContents* web_contents,
36 AwContentsClientBridgeBase* handler); 36 AwContentsClientBridgeBase* handler);
37 static void Disassociate(content::WebContents* web_contents);
37 static AwContentsClientBridgeBase* FromWebContents( 38 static AwContentsClientBridgeBase* FromWebContents(
38 content::WebContents* web_contents); 39 content::WebContents* web_contents);
39 static AwContentsClientBridgeBase* FromID(int render_process_id, 40 static AwContentsClientBridgeBase* FromID(int render_process_id,
40 int render_frame_id); 41 int render_frame_id);
41 42
42 virtual ~AwContentsClientBridgeBase(); 43 virtual ~AwContentsClientBridgeBase();
43 44
44 virtual void AllowCertificateError(int cert_error, 45 virtual void AllowCertificateError(int cert_error,
45 net::X509Certificate* cert, 46 net::X509Certificate* cert,
46 const GURL& request_url, 47 const GURL& request_url,
(...skipping 16 matching lines...) Expand all
63 const base::string16& message_text, 64 const base::string16& message_text,
64 const content::JavaScriptDialogManager::DialogClosedCallback& callback) 65 const content::JavaScriptDialogManager::DialogClosedCallback& callback)
65 = 0; 66 = 0;
66 67
67 virtual bool ShouldOverrideUrlLoading(const base::string16& url) = 0; 68 virtual bool ShouldOverrideUrlLoading(const base::string16& url) = 0;
68 }; 69 };
69 70
70 } // namespace android_webview 71 } // namespace android_webview
71 72
72 #endif // ANDROID_WEBVIEW_BROWSER_AW_CONTENTS_CLIENT_BRIDGE_BASE_H_ 73 #endif // ANDROID_WEBVIEW_BROWSER_AW_CONTENTS_CLIENT_BRIDGE_BASE_H_
OLDNEW
« no previous file with comments | « no previous file | android_webview/browser/aw_contents_client_bridge_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698