Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: Source/bindings/core/v8/custom/V8HTMLMediaElementCustom.cpp

Issue 545933002: Implement HTMLMediaElement::srcObject. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: New approach - with #includes that violate checkdeps rules Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/media/mediastream-srcobject-expected.txt ('k') | Source/bindings/core/v8/custom/custom.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8HTMLMediaElementCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8HTMLMediaElementCustom.cpp b/Source/bindings/core/v8/custom/V8HTMLMediaElementCustom.cpp
new file mode 100644
index 0000000000000000000000000000000000000000..2cbf3d25327b02d165beeb58666328628d13c0bd
--- /dev/null
+++ b/Source/bindings/core/v8/custom/V8HTMLMediaElementCustom.cpp
@@ -0,0 +1,74 @@
+/*
+ * Copyright (C) 2014 Google Inc. All rights reserved.
philipj_slow 2014/09/09 08:15:14 New code should use a shorter copyright header, se
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ * * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ * * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ * * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "bindings/core/v8/V8HTMLMediaElement.h"
+
+#include "bindings/modules/v8/V8MediaSource.h"
perkj_chrome 2014/09/08 18:45:43 big no no I guess, and check deps complains. So h
philipj_slow 2014/09/09 08:15:15 I haven't had a similar situation before, but quit
+#include "bindings/modules/v8/V8MediaStream.h"
+
+#include "core/html/MediaProvider.h"
+
+namespace blink {
+
+static v8::Handle<v8::Value> toV8Object(MediaProvider* provider, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+{
+ if (provider && provider->mediaStream())
+ return toV8(provider->mediaStream(), creationContext, isolate);
+ if (provider && provider->mediaSource())
+ return toV8(provider->mediaSource(), creationContext, isolate);
+
+ return v8Undefined();
+}
+
+static PassRefPtrWillBeRawPtr<MediaProvider> toMediaProvider(v8::Handle<v8::Value> value, v8::Isolate* isolate)
haraken 2014/09/09 08:06:02 Can you implement this logic inside HTMLMediaEleme
+{
+ if (value.IsEmpty())
+ return RefPtrWillBeRawPtr<MediaProvider>();
+
+ RefPtrWillBeRawPtr<MediaProvider> mediaProvider = MediaProvider::createFromMediaStream(V8MediaStream::toNativeWithTypeCheck(isolate, value));
+ if (mediaProvider)
+ return mediaProvider;
+ return MediaProvider::createFromMediaSource(V8MediaSource::toNativeWithTypeCheck(isolate, value));
+ //return NULL; // CanvasStyle::createFromPattern(V8CanvasPattern::toNativeWithTypeCheck(isolate, value));
+}
+
+void blink::V8HTMLMediaElement::srcObjectAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Value>& info) {
+ HTMLMediaElement* impl = V8HTMLMediaElement::toNative(info.Holder());
+ v8SetReturnValue(info, toV8Object(impl->srcObject(), info.Holder(), info.GetIsolate()));
+}
+
+void blink::V8HTMLMediaElement::srcObjectAttributeSetterCustom(v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info) {
+ HTMLMediaElement* impl = V8HTMLMediaElement::toNative(info.Holder());
+ impl->setSrcObject(toMediaProvider(value, info.GetIsolate()));
+}
+
+} // namespace blink
+
« no previous file with comments | « LayoutTests/media/mediastream-srcobject-expected.txt ('k') | Source/bindings/core/v8/custom/custom.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698