Implement HTMLMediaElement::srcObject.

Source/bindings/core/v8/custom/V8HTMLMediaElementCustom.cpp

+/*
+ * Copyright (C) 2014 Google Inc. All rights reserved.

[philipj_slow, 2014/09/09 08:15:14]

New code should use a shorter copyright header, see e.g. HTMLMenuItemElement.idl

+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#include "config.h"
+#include "bindings/core/v8/V8HTMLMediaElement.h"
+
+#include "bindings/modules/v8/V8MediaSource.h"

[perkj_chrome, 2014/09/08 18:45:43]

big no no I guess, and check deps complains. 
So how do I implement srcObjectAttributeGetterCustom to avoid this but still
make sure HTMLMediaElement::srcObject returns the correct type? 

Implement MediaProvider in modules and add srcObject as partial interface to the
HTMLMediaElement in modules?

[philipj_slow, 2014/09/09 08:15:15]

I haven't had a similar situation before, but quite clearly it's not intended
that Source/core/ include from Source/modules/.

To break the dependency, I suppose one could have a system where
modules/mediastream/ registers a converter class with core that is able to
convert between e.g. MediaStream* and the V8 types. Similar to
MediaStreamRegistry::MediaStreamRegistry(), which calls
HTMLMediaElement::setMediaStreamRegistry(this).

+#include "bindings/modules/v8/V8MediaStream.h"
+
+#include "core/html/MediaProvider.h"
+
+namespace blink {
+
+static v8::Handle<v8::Value> toV8Object(MediaProvider* provider, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)
+{
+    if (provider && provider->mediaStream())
+        return toV8(provider->mediaStream(), creationContext, isolate);
+    if (provider && provider->mediaSource())
+        return toV8(provider->mediaSource(), creationContext, isolate);
+
+    return v8Undefined();
+}
+
+static PassRefPtrWillBeRawPtr<MediaProvider> toMediaProvider(v8::Handle<v8::Value> value, v8::Isolate* isolate)

[haraken, 2014/09/09 08:06:02]

Can you implement this logic inside HTMLMediaElement::setSrcObject so that we
don't need custom bindings?

+{
+    if (value.IsEmpty())
+        return RefPtrWillBeRawPtr<MediaProvider>();
+
+    RefPtrWillBeRawPtr<MediaProvider> mediaProvider = MediaProvider::createFromMediaStream(V8MediaStream::toNativeWithTypeCheck(isolate, value));
+    if (mediaProvider)
+        return mediaProvider;
+    return MediaProvider::createFromMediaSource(V8MediaSource::toNativeWithTypeCheck(isolate, value));
+    //return NULL; // CanvasStyle::createFromPattern(V8CanvasPattern::toNativeWithTypeCheck(isolate, value));
+}
+
+void blink::V8HTMLMediaElement::srcObjectAttributeGetterCustom(const v8::PropertyCallbackInfo<v8::Value>& info) {
+    HTMLMediaElement* impl = V8HTMLMediaElement::toNative(info.Holder());
+    v8SetReturnValue(info, toV8Object(impl->srcObject(), info.Holder(), info.GetIsolate()));
+}
+
+void blink::V8HTMLMediaElement::srcObjectAttributeSetterCustom(v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<void>& info) {
+    HTMLMediaElement* impl = V8HTMLMediaElement::toNative(info.Holder());
+    impl->setSrcObject(toMediaProvider(value, info.GetIsolate()));
+}
+
+} // namespace blink
+