Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 545863002: Fix AccessibilityModeTest.* on Win 8 (Closed)

Created:
6 years, 3 months ago by drbasic
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix AccessibilityModeTest.* on Win 8 On Windows 8, always enabled accessibility for editable text controls. So the base accessibility is AccessibilityModeEditableTextOnly. R=aboxhall@chromium.org BUG= Committed: https://crrev.com/6878ed8dd9ae224e894ea2c17d8c05fb26a20412 Cr-Commit-Position: refs/heads/master@{#296562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -25 lines) Patch
M content/browser/accessibility/accessibility_mode_browsertest.cc View 4 chunks +40 lines, -10 lines 0 comments Download
M content/browser/accessibility/accessibility_mode_helper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/accessibility/accessibility_mode_helper.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M content/browser/accessibility/accessibility_mode_helper_unittest.cc View 2 chunks +4 lines, -15 lines 0 comments Download
M content/browser/accessibility/accessibility_win_browsertest.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
drbasic
6 years, 3 months ago (2014-09-05 09:16:50 UTC) #1
drbasic
Please, take a look.
6 years, 3 months ago (2014-09-17 03:29:22 UTC) #3
dmazzoni
lgtm
6 years, 3 months ago (2014-09-24 22:14:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/545863002/1
6 years, 3 months ago (2014-09-24 22:16:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as b5a69769690d956a5195b78e863d4079883254c2
6 years, 3 months ago (2014-09-24 23:35:04 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 23:47:01 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6878ed8dd9ae224e894ea2c17d8c05fb26a20412
Cr-Commit-Position: refs/heads/master@{#296562}

Powered by Google App Engine
This is Rietveld 408576698