Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: content/browser/accessibility/accessibility_mode_browsertest.cc

Issue 545863002: Fix AccessibilityModeTest.* on Win 8 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/accessibility/accessibility_mode_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/accessibility/accessibility_mode_browsertest.cc
diff --git a/content/browser/accessibility/accessibility_mode_browsertest.cc b/content/browser/accessibility/accessibility_mode_browsertest.cc
index 9e85a9aacb4c211881426a9737661a9320fc9427..656e009783ab9432ecd11eb5c4dac07b8dfa2ae3 100644
--- a/content/browser/accessibility/accessibility_mode_browsertest.cc
+++ b/content/browser/accessibility/accessibility_mode_browsertest.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "content/browser/accessibility/accessibility_mode_helper.h"
#include "content/browser/renderer_host/render_view_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_impl.h"
#include "content/browser/renderer_host/render_widget_host_view_base.h"
@@ -40,36 +41,62 @@ class AccessibilityModeTest : public ContentBrowserTest {
web_contents()->GetRootBrowserAccessibilityManager()) << message;
}
}
+
+ AccessibilityMode CorrectedAccessibility(AccessibilityMode mode) {
+ return AddAccessibilityModeTo(GetBaseAccessibilityMode(), mode);
+ }
+
+ bool ShouldBeBrowserAccessibilityManager(AccessibilityMode mode) {
+ mode = CorrectedAccessibility(mode);
+ switch (mode) {
+ case AccessibilityModeOff:
+ case AccessibilityModeTreeOnly:
+ return false;
+ case AccessibilityModeEditableTextOnly:
+ case AccessibilityModeComplete:
+ return true;
+ default:
+ NOTREACHED();
+ }
+ return false;
+ }
};
IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AccessibilityModeOff) {
NavigateToURL(shell(), GURL(kMinimalPageDataURL));
- EXPECT_EQ(AccessibilityModeOff, web_contents()->GetAccessibilityMode());
- ExpectBrowserAccessibilityManager(false);
+ EXPECT_EQ(CorrectedAccessibility(AccessibilityModeOff),
+ web_contents()->GetAccessibilityMode());
+ ExpectBrowserAccessibilityManager(
+ ShouldBeBrowserAccessibilityManager(AccessibilityModeOff));
}
IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AccessibilityModeComplete) {
NavigateToURL(shell(), GURL(kMinimalPageDataURL));
- ASSERT_EQ(AccessibilityModeOff, web_contents()->GetAccessibilityMode());
+ ASSERT_EQ(CorrectedAccessibility(AccessibilityModeOff),
+ web_contents()->GetAccessibilityMode());
AccessibilityNotificationWaiter waiter(shell());
web_contents()->AddAccessibilityMode(AccessibilityModeComplete);
EXPECT_EQ(AccessibilityModeComplete, web_contents()->GetAccessibilityMode());
waiter.WaitForNotification();
- ExpectBrowserAccessibilityManager(true);
+ ExpectBrowserAccessibilityManager(
+ ShouldBeBrowserAccessibilityManager(AccessibilityModeComplete));
}
IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AccessibilityModeTreeOnly) {
NavigateToURL(shell(), GURL(kMinimalPageDataURL));
- ASSERT_EQ(AccessibilityModeOff, web_contents()->GetAccessibilityMode());
+ ASSERT_EQ(CorrectedAccessibility(AccessibilityModeOff),
+ web_contents()->GetAccessibilityMode());
AccessibilityNotificationWaiter waiter(shell());
web_contents()->AddAccessibilityMode(AccessibilityModeTreeOnly);
- EXPECT_EQ(AccessibilityModeTreeOnly, web_contents()->GetAccessibilityMode());
+ EXPECT_EQ(CorrectedAccessibility(AccessibilityModeTreeOnly),
+ web_contents()->GetAccessibilityMode());
waiter.WaitForNotification();
// No BrowserAccessibilityManager expected for AccessibilityModeTreeOnly
- ExpectBrowserAccessibilityManager(false);
+ ExpectBrowserAccessibilityManager(
+ ShouldBeBrowserAccessibilityManager(AccessibilityModeTreeOnly));
}
IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AddingModes) {
@@ -77,9 +104,11 @@ IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AddingModes) {
AccessibilityNotificationWaiter waiter(shell());
web_contents()->AddAccessibilityMode(AccessibilityModeTreeOnly);
- EXPECT_EQ(AccessibilityModeTreeOnly, web_contents()->GetAccessibilityMode());
+ EXPECT_EQ(CorrectedAccessibility(AccessibilityModeTreeOnly),
+ web_contents()->GetAccessibilityMode());
waiter.WaitForNotification();
- ExpectBrowserAccessibilityManager(false,
+ ExpectBrowserAccessibilityManager(ShouldBeBrowserAccessibilityManager(
+ AccessibilityModeTreeOnly),
"Should be no BrowserAccessibilityManager "
"for AccessibilityModeTreeOnly");
@@ -87,7 +116,8 @@ IN_PROC_BROWSER_TEST_F(AccessibilityModeTest, AddingModes) {
web_contents()->AddAccessibilityMode(AccessibilityModeComplete);
EXPECT_EQ(AccessibilityModeComplete, web_contents()->GetAccessibilityMode());
waiter2.WaitForNotification();
- ExpectBrowserAccessibilityManager(true,
+ ExpectBrowserAccessibilityManager(ShouldBeBrowserAccessibilityManager(
+ AccessibilityModeComplete),
"Should be a BrowserAccessibilityManager "
"for AccessibilityModeComplete");
}
« no previous file with comments | « no previous file | content/browser/accessibility/accessibility_mode_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698