Extract webkit_child target from glue.

Extract webkit_child target from glue.

BUG=239107
TEST=everything still builds
R=jamesr@chromium.org
TBR=darin

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233408

[tfarina, 2013-11-04 23:57:27]

ping?

[jamesr, 2013-11-05 01:11:12]

lgtm, sorry about the delay. Slipped through my inbox.

https://codereview.chromium.org/54583005/diff/30001/webkit/child/webkit_child...
File webkit/child/webkit_child.gyp (right):

https://codereview.chromium.org/54583005/diff/30001/webkit/child/webkit_child...
webkit/child/webkit_child.gyp:1: # Copyright (c) 2012 The Chromium Authors. All
rights reserved.
2013

https://codereview.chromium.org/54583005/diff/30001/webkit/child/webkit_child...
webkit/child/webkit_child.gyp:54: 'hard_dependency': 1,
was there a comment in the original source about why this is a hard_dependency?
Do you know why it is?  It'd be useful to have a reference here if we have one.

[tfarina, 2013-11-05 01:23:30]

https://codereview.chromium.org/54583005/diff/30001/webkit/child/webkit_child...
File webkit/child/webkit_child.gyp (right):

https://codereview.chromium.org/54583005/diff/30001/webkit/child/webkit_child...
webkit/child/webkit_child.gyp:54: 'hard_dependency': 1,
On 2013/11/05 01:11:12, jamesr wrote:
> was there a comment in the original source about why this is a
hard_dependency?
> Do you know why it is?  It'd be useful to have a reference here if we have
one.
Scott, you added it in https://codereview.chromium.org/20003004. Do you remember
why it was necessary?

[scottmg, 2013-11-05 01:27:56]

https://codereview.chromium.org/54583005/diff/30001/webkit/child/webkit_child...
File webkit/child/webkit_child.gyp (right):

https://codereview.chromium.org/54583005/diff/30001/webkit/child/webkit_child...
webkit/child/webkit_child.gyp:54: 'hard_dependency': 1,
On 2013/11/05 01:23:31, tfarina wrote:
> On 2013/11/05 01:11:12, jamesr wrote:
> > was there a comment in the original source about why this is a
> hard_dependency?
> > Do you know why it is?  It'd be useful to have a reference here if we have
> one.
> Scott, you added it in https://codereview.chromium.org/20003004. Do you
remember
> why it was necessary?

Sorry, I don't.

I would guess either:
1) the jni header directory above it, or
2) copy-pasta.

I would try removing it to discover a reason or hopefully that it's unnecessary.

[tfarina, 2013-11-05 01:31:24]

https://codereview.chromium.org/54583005/diff/30001/webkit/child/webkit_child...
File webkit/child/webkit_child.gyp (right):

https://codereview.chromium.org/54583005/diff/30001/webkit/child/webkit_child...
webkit/child/webkit_child.gyp:54: 'hard_dependency': 1,
On 2013/11/05 01:27:57, scottmg wrote:
> On 2013/11/05 01:23:31, tfarina wrote:
> > On 2013/11/05 01:11:12, jamesr wrote:
> > > was there a comment in the original source about why this is a
> > hard_dependency?
> > > Do you know why it is?  It'd be useful to have a reference here if we have
> > one.
> > Scott, you added it in https://codereview.chromium.org/20003004. Do you
> remember
> > why it was necessary?
> 
> Sorry, I don't.
> 
> I would guess either:
> 1) the jni header directory above it
ah, ok. this matches with what is said about the hard_dependency in
remoting/remoting.gyp.

OK to copy that comment over here?

[commit-bot: I haz the power, 2013-11-05 21:48:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/54583005/190001

[commit-bot: I haz the power, 2013-11-06 02:26:30]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-11-06 02:39:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/54583005/190001

[commit-bot: I haz the power, 2013-11-06 06:18:45]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-11-06 16:06:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/54583005/190001

[commit-bot: I haz the power, 2013-11-06 19:56:15]

Retried try job too often on linux_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-11-06 20:57:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/54583005/190001

[commit-bot: I haz the power, 2013-11-06 23:06:28]

Change committed as 233408