Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 20003004: reland crrev.com/212927 Move webkitplatformsupport_impl and related from glue to child (Closed)

Created:
7 years, 5 months ago by scottmg
Modified:
7 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, michaeln, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, shishir+watch_chromium.org, grt+watch_chromium.org, amit, Paweł Hajdan Jr., jam, joi+watch-content_chromium.org, dominich+watch_chromium.org, robertshield, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org
Visibility:
Public.

Description

reland crrev.com/212927 Move webkitplatformsupport_impl and related from glue to child Win x64 warning suppression, and allocator dependency on linux for shared_library build compared to previous land. TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213033

Patch Set 1 #

Patch Set 2 : rebase & allocator dep for components_unittests in shared_library2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+286 lines, -4468 lines) Patch
M android_webview/tools/third_party_files_whitelist.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/captive_portal/captive_portal_tab_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_helpers.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/user_script_listener.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/net/resource_prefetch_predictor_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_tables.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/predictors/predictors_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_renderer.gypi View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/common/automation_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/DEPS View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/content_settings_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_localization_peer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_localization_peer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/security_filter_peer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/plugin_url_request.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/child_process_security_policy_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/offline_policy_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_dispatcher_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_message_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_request_info_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/loader/resource_scheduler_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_error_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_policy.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_policy.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/ssl/ssl_request_info.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/child/child_thread.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/database_util.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/request_extra_data.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/resource_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M content/child/resource_dispatcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/child/socket_stream_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/content_param_traits_macros.h View 1 chunk +1 line, -1 line 0 comments Download
M content/common/resource_messages.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/socket_stream_handle_data.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/content_child.gypi View 4 chunks +8 lines, -7 lines 0 comments Download
M content/content_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_tests.gypi View 2 chunks +1 line, -1 line 0 comments Download
M content/public/browser/content_browser_client.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/load_from_memory_cache_details.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/resource_dispatcher_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/resource_request_details.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/resource_request_info.h View 1 chunk +1 line, -1 line 0 comments Download
D content/public/common/resource_dispatcher_delegate.h View 1 chunk +0 lines, -32 lines 0 comments Download
M content/public/common/resource_response.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 1 4 chunks +18 lines, -18 lines 0 comments Download
M content/renderer/renderer_main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/webplugin_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/appcache/appcache_host.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/appcache/appcache_interceptor.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/browser/appcache/appcache_request_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/child/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A + webkit/child/ftp_directory_listing_response_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + webkit/child/multipart_response_delegate.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + webkit/child/multipart_response_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/child/multipart_response_delegate_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + webkit/child/resource_loader_bridge.h View 7 chunks +10 lines, -10 lines 0 comments Download
A + webkit/child/resource_loader_bridge.cc View 1 chunk +2 lines, -1 line 0 comments Download
A webkit/child/webkit_child_helpers.h View 1 chunk +21 lines, -0 lines 0 comments Download
A webkit/child/webkit_child_helpers.cc View 1 chunk +53 lines, -0 lines 0 comments Download
M webkit/child/webkitplatformsupport_child_impl.h View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/child/webkitplatformsupport_impl.h View 4 chunks +6 lines, -6 lines 0 comments Download
A + webkit/child/webkitplatformsupport_impl.cc View 4 chunks +6 lines, -3 lines 0 comments Download
A + webkit/child/websocketstreamhandle_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + webkit/child/weburlloader_impl.h View 2 chunks +3 lines, -4 lines 0 comments Download
A + webkit/child/weburlloader_impl.cc View 2 chunks +8 lines, -8 lines 0 comments Download
A + webkit/child/weburlrequest_extradata_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + webkit/child/weburlrequest_extradata_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/child/weburlresponse_extradata_impl.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + webkit/child/weburlresponse_extradata_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/resource_request_body.h View 1 chunk +1 line, -1 line 0 comments Download
A + webkit/common/resource_type.h View 3 chunks +5 lines, -5 lines 0 comments Download
A + webkit/common/resource_type.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/common/webkit_common.gyp View 3 chunks +4 lines, -2 lines 0 comments Download
D webkit/glue/ftp_directory_listing_response_delegate.h View 1 chunk +0 lines, -53 lines 0 comments Download
D webkit/glue/ftp_directory_listing_response_delegate.cc View 1 chunk +0 lines, -123 lines 0 comments Download
D webkit/glue/multipart_response_delegate.h View 1 chunk +0 lines, -153 lines 0 comments Download
D webkit/glue/multipart_response_delegate.cc View 1 chunk +0 lines, -404 lines 0 comments Download
D webkit/glue/multipart_response_delegate_unittest.cc View 1 chunk +0 lines, -675 lines 0 comments Download
D webkit/glue/resource_loader_bridge.h View 1 chunk +0 lines, -232 lines 0 comments Download
D webkit/glue/resource_loader_bridge.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D webkit/glue/resource_type.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webkit/glue/resource_type.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M webkit/glue/webkit_glue.h View 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/glue/webkit_glue.cc View 1 chunk +0 lines, -35 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 6 chunks +36 lines, -16 lines 0 comments Download
M webkit/glue/webkit_glue_common.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M webkit/glue/webkit_glue_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D webkit/glue/webkitplatformsupport_impl.h View 1 chunk +0 lines, -155 lines 0 comments Download
D webkit/glue/webkitplatformsupport_impl.cc View 1 chunk +0 lines, -901 lines 0 comments Download
D webkit/glue/websocketstreamhandle_delegate.h View 1 chunk +0 lines, -44 lines 0 comments Download
D webkit/glue/websocketstreamhandle_impl.h View 1 chunk +0 lines, -40 lines 0 comments Download
D webkit/glue/websocketstreamhandle_impl.cc View 1 chunk +0 lines, -196 lines 0 comments Download
D webkit/glue/weburlloader_impl.h View 1 chunk +0 lines, -45 lines 0 comments Download
D webkit/glue/weburlloader_impl.cc View 1 chunk +0 lines, -854 lines 0 comments Download
D webkit/glue/weburlrequest_extradata_impl.h View 1 chunk +0 lines, -45 lines 0 comments Download
D webkit/glue/weburlrequest_extradata_impl.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D webkit/glue/weburlresponse_extradata_impl.h View 1 chunk +0 lines, -96 lines 0 comments Download
D webkit/glue/weburlresponse_extradata_impl.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M webkit/mocks/mock_weburlloader.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/ppapi/url_request_info_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/plugins/webkit_plugins.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/support/test_webkit_platform_support.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M webkit/support/webkit_support.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
scottmg
7 years, 5 months ago (2013-07-23 02:45:51 UTC) #1
Message was sent while issue was closed. 
Committed patchset #2 manually as r213033 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698