Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Issue 545773003: Allocate a new empty number dictionary when resetting elements (Closed)

Created:
6 years, 3 months ago by Toon Verwaest
Modified:
6 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Allocate a new empty number dictionary when resetting elements BUG=410332 LOG=y R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23727

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M src/objects.cc View 1 chunk +9 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-reset-dictionary-elements.js View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Toon Verwaest
PTAL
6 years, 3 months ago (2014-09-05 11:14:09 UTC) #2
Yang
On 2014/09/05 11:14:09, Toon Verwaest wrote: > PTAL lgtm.
6 years, 3 months ago (2014-09-05 11:36:23 UTC) #3
Toon Verwaest
6 years, 3 months ago (2014-09-05 11:38:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23727 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698