src/objects-inl.h - Issue 545773003: Allocate a new empty number dictionary when resetting elements

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 545773003: Allocate a new empty number dictionary when resetting elements (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index 2123fa6e128154631a9d83a407420fcea173d336..083d671d525c045e188891f8267d5ace655696e8 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -2897,9 +2897,6 @@ FixedArrayBase* Map::GetInitialElements() {

GetHeap()->EmptyFixedTypedArrayForMap(this);

DCHECK(!GetHeap()->InNewSpace(empty_array));

return empty_array;

- } else if (has_dictionary_elements()) {

- DCHECK(!GetHeap()->InNewSpace(GetHeap()->empty_slow_element_dictionary()));

- return GetHeap()->empty_slow_element_dictionary();

} else {

UNREACHABLE();

}

« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/regress/regress-reset-dictionary-elements.js » ('j') | no next file with comments »