chrome/browser/notifications/notification_conversion_helper.cc - Issue 545513002: tryAllocPixels returns bool, allocPixels requires success

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_conversion_helper.cc

Issue 545513002: tryAllocPixels returns bool, allocPixels requires success (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/resources/bitmap_content_layer_updater.cc ('K') | « cc/resources/bitmap_content_layer_updater.cc ('k') | chrome/browser/themes/browser_theme_pack.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_conversion_helper.cc

diff --git a/chrome/browser/notifications/notification_conversion_helper.cc b/chrome/browser/notifications/notification_conversion_helper.cc

index 800adc11c620a685ea9f8a419625689ed5fe9a3e..dc2c1f5ae09c1fd10b865a56431401df465b5d68 100644

--- a/chrome/browser/notifications/notification_conversion_helper.cc

+++ b/chrome/browser/notifications/notification_conversion_helper.cc

@@ -168,7 +168,7 @@ bool NotificationConversionHelper::NotificationBitmapToGfxImage(

SkBitmap bitmap;

// Allocate the actual backing store with the sanitized dimensions.

- if (!bitmap.allocN32Pixels(width, height))

+ if (!bitmap.tryAllocN32Pixels(width, height))

return false;

// Ensure that our bitmap and our data now refer to the same number of pixels.

« cc/resources/bitmap_content_layer_updater.cc ('K') | « cc/resources/bitmap_content_layer_updater.cc ('k') | chrome/browser/themes/browser_theme_pack.cc » ('j') | no next file with comments »