cc/resources/bitmap_content_layer_updater.cc - Issue 545513002: tryAllocPixels returns bool, allocPixels requires success

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/bitmap_content_layer_updater.cc

Issue 545513002: tryAllocPixels returns bool, allocPixels requires success (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/resources/bitmap_content_layer_updater.cc

diff --git a/cc/resources/bitmap_content_layer_updater.cc b/cc/resources/bitmap_content_layer_updater.cc

index fff62cf0aca5ca144a27be12614f1100d2815f46..5588b0730e35aa87dad4bd3a20d1a00600cb567b 100644

--- a/cc/resources/bitmap_content_layer_updater.cc

+++ b/cc/resources/bitmap_content_layer_updater.cc

@@ -64,10 +64,9 @@ void BitmapContentLayerUpdater::PrepareToUpdate(

devtools_instrumentation::ScopedLayerTask paint_setup(

devtools_instrumentation::kPaintSetup, layer_id_);

canvas_size_ = content_rect.size();

- bool alloc = bitmap_backing_.allocN32Pixels(

+ bitmap_backing_.allocN32Pixels(

canvas_size_.width(), canvas_size_.height(), layer_is_opaque_);

// TODO(danak): Remove when skia does the check for us: crbug.com/360384

danakj 2014/09/04 14:28:47 remove this TODO also

- CHECK(alloc);

canvas_ = skia::AdoptRef(new SkCanvas(bitmap_backing_));

DCHECK_EQ(content_rect.width(), canvas_->getBaseLayerSize().width());

DCHECK_EQ(content_rect.height(), canvas_->getBaseLayerSize().height());

« no previous file with comments | « cc/output/software_renderer.cc ('k') | chrome/browser/notifications/notification_conversion_helper.cc » ('j') | no next file with comments »