cc/output/software_renderer.cc - Issue 545513002: tryAllocPixels returns bool, allocPixels requires success

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/software_renderer.cc

Issue 545513002: tryAllocPixels returns bool, allocPixels requires success (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/software_renderer.cc

diff --git a/cc/output/software_renderer.cc b/cc/output/software_renderer.cc

index 88b9c646c924956c054074ad6d7c804442a2fdd5..9dd26fb01ad10e1d885a0909cadb5b7d4716af6e 100644

--- a/cc/output/software_renderer.cc

+++ b/cc/output/software_renderer.cc

@@ -487,7 +487,7 @@ void SoftwareRenderer::DrawRenderPassQuad(const DrawingFrame* frame,

if (filter) {

SkImageInfo info = SkImageInfo::MakeN32Premul(

content_texture->size().width(), content_texture->size().height());

- if (filter_bitmap.allocPixels(info)) {

+ if (filter_bitmap.tryAllocPixels(info)) {

SkCanvas canvas(filter_bitmap);

SkPaint paint;

paint.setImageFilter(filter.get());

« no previous file with comments | « no previous file | cc/resources/bitmap_content_layer_updater.cc » ('j') | cc/resources/bitmap_content_layer_updater.cc » ('J')