Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 545373004: Temporarily stop launching Chrome in installer test runs. (Closed)

Created:
6 years, 3 months ago by grt (UTC plus 2)
Modified:
6 years, 3 months ago
Reviewers:
gab
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@log
Project:
chromium
Visibility:
Public.

Description

Temporarily stop launching Chrome in installer test runs. The bot runner dies sometimes when running this test. Disable the part of the test that launches Chrome to see if that makes the failures go away. This change also makes the logs a bit more informative by added date, time, file, and line info in the same format as Chrome's logging. It also enables verbose logging for Chrome's installer. BUG=402081 NOTRY=true TBR=gab@chromium.org Committed: https://crrev.com/033f3af0a8b2dc3286d764ffc6140f687085fe66 Cr-Commit-Position: refs/heads/master@{#294180}

Patch Set 1 #

Patch Set 2 : sync to commit position 294174 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -15 lines) Patch
M chrome/test/mini_installer/config/chrome_system_installed.prop View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer/config/chrome_user_installed.prop View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/mini_installer/config/config.config View 1 3 chunks +2 lines, -6 lines 0 comments Download
M chrome/test/mini_installer/quit_chrome.py View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/mini_installer/test_installer.py View 1 5 chunks +22 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
grt (UTC plus 2)
Hi Gab. Please take a look. I'll land this straight away once it passes on ...
6 years, 3 months ago (2014-09-10 15:17:16 UTC) #1
grt (UTC plus 2)
On 2014/09/10 15:17:16, grt wrote: > Hi Gab. Please take a look. I'll land this ...
6 years, 3 months ago (2014-09-10 16:45:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grt@chromium.org/545373004/20001
6 years, 3 months ago (2014-09-10 16:46:33 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 32124f57f8b6298590cd1a533d0be40cb06ebe97
6 years, 3 months ago (2014-09-10 16:52:47 UTC) #5
gab
lgtm
6 years, 3 months ago (2014-09-10 16:53:51 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 16:55:01 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/033f3af0a8b2dc3286d764ffc6140f687085fe66
Cr-Commit-Position: refs/heads/master@{#294180}

Powered by Google App Engine
This is Rietveld 408576698