chrome/test/mini_installer/quit_chrome.py - Issue 545373004: Temporarily stop launching Chrome in installer test runs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/mini_installer/quit_chrome.py

Issue 545373004: Temporarily stop launching Chrome in installer test runs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@log

Patch Set: sync to commit position 294174 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/mini_installer/quit_chrome.py

diff --git a/chrome/test/mini_installer/quit_chrome.py b/chrome/test/mini_installer/quit_chrome.py

index 4dbf78d43dc3eeb8429b36cad9e12f44cbe5e4ed..c25d8da4d27e62772159f4adb4362a85ed1032f6 100644

--- a/chrome/test/mini_installer/quit_chrome.py

+++ b/chrome/test/mini_installer/quit_chrome.py

@@ -69,7 +69,8 @@ def QuitChrome(chrome_path):

"""

if not CloseWindows(chrome_path):

# TODO(robertshield): Investigate why Chrome occasionally doesn't shut down.

- print 'Warning: Chrome not responding to window closure. Killing process...'

+ sys.stderr.write('Warning: Chrome not responding to window closure. '

+ 'Killing all processes belonging to %s\n' % chrome_path)

KillNamedProcess(chrome_path)

« no previous file with comments | « chrome/test/mini_installer/config/config.config ('k') | chrome/test/mini_installer/test_installer.py » ('j') | no next file with comments »