Make ui gn check pass. Misc GN build improvements.

Make ui gn check pass. Misc GN build improvements.

Content/public/app was messed up and didn't link everything properly, so this separates it out into browser and child like content/app is.

R=jamesr@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/b41a8d6e789ac5df9a6d314cd0ad59f584f53dea

[brettw, 2014-09-05 18:25:44]

brettw@chromium.org changed reviewers:
+ jamesr@chromium.org

[jamesr, 2014-09-05 23:26:06]

lgtm

https://codereview.chromium.org/545313002/diff/40001/content/public/app/BUILD.gn
File content/public/app/BUILD.gn (right):

https://codereview.chromium.org/545313002/diff/40001/content/public/app/BUILD...
content/public/app/BUILD.gn:5: # Used internally to hold the sources shared
between the various targets below.
add a visibility restriction?

[brettw, 2014-09-05 23:27:33]

On 2014/09/05 23:26:06, jamesr wrote:
> lgtm
> 
>
https://codereview.chromium.org/545313002/diff/40001/content/public/app/BUILD.gn
> File content/public/app/BUILD.gn (right):
> 
>
https://codereview.chromium.org/545313002/diff/40001/content/public/app/BUILD...
> content/public/app/BUILD.gn:5: # Used internally to hold the sources shared
> between the various targets below.
> add a visibility restriction?

This prevents other targets from being able to include headers from it, and I
don't want that.

[brettw, 2014-09-05 23:34:02]

Committed patchset #3 (id:40001) manually as b41a8d6.

[Nico, 2014-09-06 00:04:23]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/546943003/ by thakis@chromium.org.

The reason for reverting is: Broke
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/bu...

[783/786 | 258.324] LINK ./chrome
FAILED: /mnt/data/b/build/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings
-m64 -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -pthread
-B../../third_party/binutils/Linux_x64/Release/bin -fuse-ld=gold -Wl,--icf=none
-Wl,-rpath=\$ORIGIN/ -Wl,-rpath-link= -Wl,--disable-new-dtags -o
./keyboard_unittests -Wl,--start-group @./keyboard_unittests.rsp 
-Wl,--end-group  -ldl -lgmodule-2.0 -lgobject-2.0 -lgthread-2.0 -lrt -lglib-2.0
-ludev -lfontconfig -lX11 -lXcomposite -lXcursor -lXdamage -lXext -lXfixes -lXi
-lXrender -lXss -lXtst -lpangocairo-1.0 -lpango-1.0 -lcairo -lnss3 -lnssutil3
-lsmime3 -lplds4 -lplc4 -lnspr4 -lgconf-2 -lresolv -lfreetype -lasound -lXrandr
-lcups -lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err -lgcrypt -lz -lpthread -lcrypt
-lm -lcap -ldbus-1 -lcrypto -lexpat 
../../content/utility/utility_thread_impl.cc:38: error: undefined reference to
'content::UtilityThread::UtilityThread()'
../../content/utility/utility_thread_impl.cc:44: error: undefined reference to
'content::UtilityThread::UtilityThread()'
../../content/utility/utility_thread_impl.cc:49: error: undefined reference to
'content::UtilityThread::~UtilityThread()'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed..

[commit-bot: I haz the power, 2014-09-10 03:41:53]

Patchset 3 (id:??) landed as
https://crrev.com/b41a8d6e789ac5df9a6d314cd0ad59f584f53dea
Cr-Commit-Position: refs/heads/master@{#293592}