Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: ui/resources/BUILD.gn

Issue 545313002: Make ui gn check pass. Misc GN build improvements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: link chrome Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/resources/BUILD.gn
diff --git a/ui/resources/BUILD.gn b/ui/resources/BUILD.gn
index e4dbd9386e0d6e5f0e5308a65388cfe2fab04290..8101c3670b5246dc84b6e258b016bdb42f8bd780 100644
--- a/ui/resources/BUILD.gn
+++ b/ui/resources/BUILD.gn
@@ -15,7 +15,6 @@ group("resources") {
}
grit("ui_resources_grd") {
- visibility = ":resources"
source = "ui_resources.grd"
outputs = [
"grit/ui_resources.h",
@@ -27,7 +26,6 @@ grit("ui_resources_grd") {
}
grit("ui_unscaled_resources_grd") {
- visibility = ":resources"
source = "ui_unscaled_resources.grd"
outputs = [
"grit/ui_unscaled_resources.h",
@@ -36,7 +34,6 @@ grit("ui_unscaled_resources_grd") {
}
grit("webui_resources_grd") {
- visibility = ":resources"
source = "../webui/resources/webui_resources.grd"
outputs = [
"grit/webui_resources.h",

Powered by Google App Engine
This is Rietveld 408576698