Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: src/compiler/typer.cc

Issue 545223002: Fix typer to actually visit the entire graph. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/pipeline.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/typer.cc
diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc
index e898eb323dd508ab587208fcd25252cdd3e4ceb6..aaf43bb5fcd548cd44ef985307c0e1636ac52ee9 100644
--- a/src/compiler/typer.cc
+++ b/src/compiler/typer.cc
@@ -118,11 +118,15 @@ class Typer::RunVisitor : public Typer::Visitor {
phis(NodeSet::key_compare(), NodeSet::allocator_type(typer->zone())) {}
GenericGraphVisit::Control Pre(Node* node) {
- return NodeProperties::IsControl(node)
- && node->opcode() != IrOpcode::kEnd
- && node->opcode() != IrOpcode::kMerge
- && node->opcode() != IrOpcode::kReturn
- ? GenericGraphVisit::SKIP : GenericGraphVisit::CONTINUE;
+ return NodeProperties::IsControl(node) &&
+ node->opcode() != IrOpcode::kEnd &&
+ node->opcode() != IrOpcode::kMerge &&
+ node->opcode() != IrOpcode::kBranch &&
+ node->opcode() != IrOpcode::kIfTrue &&
+ node->opcode() != IrOpcode::kIfFalse &&
+ node->opcode() != IrOpcode::kReturn
+ ? GenericGraphVisit::SKIP
+ : GenericGraphVisit::CONTINUE;
titzer 2014/09/05 13:54:46 Just delete this method; I think the default will
Michael Starzinger 2014/09/05 14:58:13 Done.
}
GenericGraphVisit::Control Post(Node* node) {
« no previous file with comments | « src/compiler/pipeline.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698