Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 545193008: Use base::StringPairs where appropriate from /components (Closed)

Created:
6 years, 3 months ago by limasdf
Modified:
6 years, 3 months ago
Reviewers:
Mathieu, Ilya Sherman, boliu
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Becuase base/strings/string_split.h defines: typedef std::vector<std::pair<std::string, std::string> > StringPairs; And use iterator to iterate stl::vector element. BUG=412250 Committed: https://crrev.com/1af96aa7b7d721bad77b818166892fd413716e98 Cr-Commit-Position: refs/heads/master@{#294832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M components/auto_login_parser/auto_login_parser.cc View 1 chunk +10 lines, -8 lines 0 comments Download
M components/autofill/content/browser/wallet/wallet_client_unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M components/leveldb_proto/leveldb_database.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/leveldb_proto/leveldb_database.cc View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
limasdf
Please take a look. boliu for auto_login_parser. isherman for autofill. mathp for leveldb_proto.
6 years, 3 months ago (2014-09-14 04:24:12 UTC) #2
Ilya Sherman
autofill lgtm
6 years, 3 months ago (2014-09-15 02:45:29 UTC) #3
Mathieu
lgtm
6 years, 3 months ago (2014-09-15 13:38:32 UTC) #4
boliu
lgtm
6 years, 3 months ago (2014-09-15 14:51:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/545193008/1
6 years, 3 months ago (2014-09-15 15:03:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as d6c9923fae4c173452e7eb475c709d73a1856afb
6 years, 3 months ago (2014-09-15 16:09:39 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 16:19:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1af96aa7b7d721bad77b818166892fd413716e98
Cr-Commit-Position: refs/heads/master@{#294832}

Powered by Google App Engine
This is Rietveld 408576698