Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 544903003: Define copy rule for content_shell.pak required for running webkit_unit_tests on android. (Closed)

Created:
6 years, 3 months ago by vivekg_samsung
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Define copy rule for content_shell.pak required for running webkit_unit_tests on android. This is required for CL, https://codereview.chromium.org/456413002, to run webkit_unit_tests on android. In subsequenct CL from blink side, https://codereview.chromium.org/542003002, we should extend the android.py to start sending this file to the device under test. R=jochen@chromium.org NOTRY=true Committed: https://crrev.com/e136a86565fcf76940b8df7c51e2c41fa85a71d1 Cr-Commit-Position: refs/heads/master@{#293500}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/content_shell.gypi View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
vivekg
PTAL, thank you!
6 years, 3 months ago (2014-09-05 03:01:04 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-05 08:27:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/544903003/1
6 years, 3 months ago (2014-09-05 08:44:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vivek.vg@samsung.com/544903003/1
6 years, 3 months ago (2014-09-05 10:50:58 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 09c25825997fc7a4355a6cb156035f385f0b1d3e
6 years, 3 months ago (2014-09-05 10:52:26 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:38:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e136a86565fcf76940b8df7c51e2c41fa85a71d1
Cr-Commit-Position: refs/heads/master@{#293500}

Powered by Google App Engine
This is Rietveld 408576698