Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 544863002: Preven OOB memory access in chrome_pdf::AlphaBlend(). (Closed)

Created:
6 years, 3 months ago by Tom Sepez
Modified:
6 years, 3 months ago
Reviewers:
gene
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Preven OOB memory access in chrome_pdf::AlphaBlend(). Similar to bug 398384, but perform the same bounds check we introduced to chrome_pdf::CopyImage() in the chrome_pdf::AlphaBlend() function. Also change the return value from bool to void, since AlphaBlend() always returns true, and no-one was checking the return value anyways. BUG=384891 Committed: https://crrev.com/8f07983fb62fb48fc8298b150e4548f92a374da1 Cr-Commit-Position: refs/heads/master@{#293454}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M pdf/draw_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M pdf/draw_utils.cc View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Tom Sepez
gene, please review. Thanks.
6 years, 3 months ago (2014-09-04 22:18:08 UTC) #2
gene
lgtm
6 years, 3 months ago (2014-09-05 00:51:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/544863002/1
6 years, 3 months ago (2014-09-05 01:28:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0807a3021aaa309d9a8473c2b58238a061e64a35
6 years, 3 months ago (2014-09-05 05:43:10 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:37:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f07983fb62fb48fc8298b150e4548f92a374da1
Cr-Commit-Position: refs/heads/master@{#293454}

Powered by Google App Engine
This is Rietveld 408576698