pdf/draw_utils.h - Issue 544863002: Preven OOB memory access in chrome_pdf::AlphaBlend().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/draw_utils.h

Issue 544863002: Preven OOB memory access in chrome_pdf::AlphaBlend(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pdf/draw_utils.h

diff --git a/pdf/draw_utils.h b/pdf/draw_utils.h

index 1024037ec980fdfcfeb021f2be4c0d741cf015c4..eedf24f27d8e47b70cfe1b5abbccf3ee1b6b1b77 100644

--- a/pdf/draw_utils.h

+++ b/pdf/draw_utils.h

@@ -16,7 +16,7 @@ namespace chrome_pdf {

const uint8 kOpaqueAlpha = 0xFF;

const uint8 kTransparentAlpha = 0x00;

-bool AlphaBlend(const pp::ImageData& src, const pp::Rect& src_rc,

+void AlphaBlend(const pp::ImageData& src, const pp::Rect& src_rc,

pp::ImageData* dest, const pp::Point& dest_origin,

uint8 alpha_adjustment);

« no previous file with comments | « no previous file | pdf/draw_utils.cc » ('j') | no next file with comments »