Apply the network changed retry

components/google/core/browser/google_url_tracker.cc

Index: components/google/core/browser/google_url_tracker.cc
diff --git a/components/google/core/browser/google_url_tracker.cc b/components/google/core/browser/google_url_tracker.cc
index 0c27a436064dc0050bae50bcae53e36dd2b9f6d0..1af61b62f6dcb9f91eb3a6b1efb5d40c19256eb0 100644
--- a/components/google/core/browser/google_url_tracker.cc
+++ b/components/google/core/browser/google_url_tracker.cc
@@ -246,9 +246,11 @@ void GoogleURLTracker::StartFetchIfDesirable() {
                          net::LOAD_DO_NOT_SAVE_COOKIES);
   fetcher_->SetRequestContext(client_->GetRequestContext());
 
-  // Configure to max_retries at most kMaxRetries times for 5xx errors.
+  // Configure to retry at most kMaxRetries times for 5xx errors.
   static const int kMaxRetries = 5;
   fetcher_->SetMaxRetriesOn5xx(kMaxRetries);
+  // Configure to retry at most kMaxRetries times for network changes.

[Peter Kasting, 2014/09/05 22:43:18]

Nit: How about this comment:

Also retry kMaxRetries times on network change errors.  A network change can
propagate through Chrome in various stages, so it's possible for this code to be
reached via OnNetworkChanged(), and then have the fetch we kick off be canceled
due to e.g. the DNS server changing at a later time.  In general it's not
possible to ensure that by the time we reach here any requests we start won't be
canceled in this fashion, so retrying is the best we can do.

[Jaekyun Seok (inactive), 2014/09/06 03:14:43]

Done.

+  fetcher_->SetAutomaticallyRetryOnNetworkChanges(kMaxRetries);
 
   fetcher_->Start();
 }