Apply the network changed retry

components/google/core/browser/google_url_tracker.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/google/core/browser/google_url_tracker.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_util.h"
@@ skipping 228 matching lines @@
   already_fetched_ = true;
   fetcher_.reset(net::URLFetcher::Create(
       fetcher_id_, GURL(kSearchDomainCheckURL), net::URLFetcher::GET, this));
   ++fetcher_id_;
   // We don't want this fetch to set new entries in the cache or cookies, lest
   // we alarm the user.
   fetcher_->SetLoadFlags(net::LOAD_DISABLE_CACHE |
                          net::LOAD_DO_NOT_SAVE_COOKIES);
   fetcher_->SetRequestContext(client_->GetRequestContext());
 
-  // Configure to max_retries at most kMaxRetries times for 5xx errors.
+  // Configure to retry at most kMaxRetries times for 5xx errors.
   static const int kMaxRetries = 5;
   fetcher_->SetMaxRetriesOn5xx(kMaxRetries);
+  // Configure to retry at most kMaxRetries times for network changes.

[Peter Kasting, 2014/09/05 22:43:18]

Nit: How about this comment:

Also retry kMaxRetries times on network change errors.  A network change can
propagate through Chrome in various stages, so it's possible for this code to be
reached via OnNetworkChanged(), and then have the fetch we kick off be canceled
due to e.g. the DNS server changing at a later time.  In general it's not
possible to ensure that by the time we reach here any requests we start won't be
canceled in this fashion, so retrying is the best we can do.

[Jaekyun Seok (inactive), 2014/09/06 03:14:43]

Done.

+  fetcher_->SetAutomaticallyRetryOnNetworkChanges(kMaxRetries);
 
   fetcher_->Start();
 }
 
 void GoogleURLTracker::OnNavigationPending(
     scoped_ptr<GoogleURLTrackerNavigationHelper> nav_helper,
     infobars::InfoBarManager* infobar_manager,
     int pending_id) {
   GoogleURLTrackerMapEntry* map_entry = NULL;
 
@@ skipping 136 matching lines @@
   }
   if (client_->IsListeningForNavigationStart()) {
     DCHECK(!search_committed_);
     client_->SetListeningForNavigationStart(false);
   }
 }
 
 void GoogleURLTracker::NotifyGoogleURLUpdated() {
   callback_list_.Notify();
 }