Apply the network changed retry

Apply the network changed retry

On android platform, it often fails to fetch searchdomaincheck url right
after network changes because of conflict between DNSObserver::OnDNSChanged
event and NetworkChangeObserver::OnNetworkChanged event.
This patch enables re-fetching when such conflict happens.

BUG=407442
Committed: https://crrev.com/da10c204068bcef07f3b7aff2f8ea85a31edbb41
Cr-Commit-Position: refs/heads/master@{#293639}

[Jaekyun Seok (inactive), 2014-09-04 21:53:01]

jaekyun@chromium.org changed reviewers:
+ pauljensen@chromium.org, pkasting@chromium.org

[Jaekyun Seok (inactive), 2014-09-04 21:53:01]

Please take a look at this change.

[pauljensen, 2014-09-05 13:22:56]

https://codereview.chromium.org/544833002/diff/1/components/google/core/brows...
File components/google/core/browser/google_url_tracker.cc (right):

https://codereview.chromium.org/544833002/diff/1/components/google/core/brows...
components/google/core/browser/google_url_tracker.cc:248: // Configure to
max_retries at most kMaxRetries times for network changes.
What is "max_retries"?  would "retry" make more sense?

[Jaekyun Seok (inactive), 2014-09-05 19:00:51]

PTAL.

https://codereview.chromium.org/544833002/diff/1/components/google/core/brows...
File components/google/core/browser/google_url_tracker.cc (right):

https://codereview.chromium.org/544833002/diff/1/components/google/core/brows...
components/google/core/browser/google_url_tracker.cc:248: // Configure to
max_retries at most kMaxRetries times for network changes.
On 2014/09/05 13:22:56, pauljensen wrote:
> What is "max_retries"?  would "retry" make more sense?

Done.

[pauljensen, 2014-09-05 19:01:50]

LGTM but I'm not an OWNER.

[Peter Kasting, 2014-09-05 22:43:18]

LGTM

https://codereview.chromium.org/544833002/diff/20001/components/google/core/b...
File components/google/core/browser/google_url_tracker.cc (right):

https://codereview.chromium.org/544833002/diff/20001/components/google/core/b...
components/google/core/browser/google_url_tracker.cc:252: // Configure to retry
at most kMaxRetries times for network changes.
Nit: How about this comment:

Also retry kMaxRetries times on network change errors.  A network change can
propagate through Chrome in various stages, so it's possible for this code to be
reached via OnNetworkChanged(), and then have the fetch we kick off be canceled
due to e.g. the DNS server changing at a later time.  In general it's not
possible to ensure that by the time we reach here any requests we start won't be
canceled in this fashion, so retrying is the best we can do.

[Jaekyun Seok (inactive), 2014-09-06 03:14:43]

https://codereview.chromium.org/544833002/diff/20001/components/google/core/b...
File components/google/core/browser/google_url_tracker.cc (right):

https://codereview.chromium.org/544833002/diff/20001/components/google/core/b...
components/google/core/browser/google_url_tracker.cc:252: // Configure to retry
at most kMaxRetries times for network changes.
On 2014/09/05 22:43:18, Peter Kasting wrote:
> Nit: How about this comment:
> 
> Also retry kMaxRetries times on network change errors.  A network change can
> propagate through Chrome in various stages, so it's possible for this code to
be
> reached via OnNetworkChanged(), and then have the fetch we kick off be
canceled
> due to e.g. the DNS server changing at a later time.  In general it's not
> possible to ensure that by the time we reach here any requests we start won't
be
> canceled in this fashion, so retrying is the best we can do.

Done.

[Jaekyun Seok (inactive), 2014-09-06 03:15:41]

The CQ bit was checked by jaekyun@chromium.org

[commit-bot: I haz the power, 2014-09-06 03:17:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jaekyun@chromium.org/544833002/40001

[commit-bot: I haz the power, 2014-09-06 05:11:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-06 05:11:08]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Jaekyun Seok (inactive), 2014-09-06 05:33:39]

The CQ bit was checked by jaekyun@chromium.org

[commit-bot: I haz the power, 2014-09-06 05:35:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jaekyun@chromium.org/544833002/40001

[commit-bot: I haz the power, 2014-09-06 12:56:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-06 12:56:41]

Exceeded time limit waiting for builds to trigger.

[Jaekyun Seok (inactive), 2014-09-06 22:09:28]

The CQ bit was checked by jaekyun@chromium.org

[commit-bot: I haz the power, 2014-09-06 22:10:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jaekyun@chromium.org/544833002/40001

[commit-bot: I haz the power, 2014-09-06 22:11:43]

Committed patchset #3 (id:40001) as 3cae18e70bd44341c2e96806763d3d92486926f9

[commit-bot: I haz the power, 2014-09-10 03:43:30]

Patchset 3 (id:??) landed as
https://crrev.com/da10c204068bcef07f3b7aff2f8ea85a31edbb41
Cr-Commit-Position: refs/heads/master@{#293639}