Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(594)

Issue 544823003: Re-enabling YUV GPU decoding (Closed)

Created:
6 years, 3 months ago by sugoi1
Modified:
6 years, 3 months ago
CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Re-enabling YUV GPU decoding BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181853

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/platform/graphics/ImageFrameGenerator.cpp View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 7 (2 generated)
sugoi1
https://codereview.chromium.org/544823003/diff/1/Source/platform/graphics/ImageFrameGenerator.cpp File Source/platform/graphics/ImageFrameGenerator.cpp (right): https://codereview.chromium.org/544823003/diff/1/Source/platform/graphics/ImageFrameGenerator.cpp#newcode72 Source/platform/graphics/ImageFrameGenerator.cpp:72: static bool updateYUVComponentSizes(ImageDecoder* decoder, SkISize componentSizes[3], ImageDecoder::SizeType sizeType) Oops, ...
6 years, 3 months ago (2014-09-11 19:57:41 UTC) #2
Stephen White
LGTM (BTW, if a tiny fix like this is blocking you and/or breaking stuff, it's ...
6 years, 3 months ago (2014-09-11 20:36:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/544823003/1
6 years, 3 months ago (2014-09-11 20:43:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 181853
6 years, 3 months ago (2014-09-11 22:47:26 UTC) #6
Noel Gordon
6 years, 3 months ago (2014-09-12 01:47:06 UTC) #7
LGTM

https://codereview.chromium.org/544823003/diff/1/Source/platform/graphics/Ima...
File Source/platform/graphics/ImageFrameGenerator.cpp (right):

https://codereview.chromium.org/544823003/diff/1/Source/platform/graphics/Ima...
Source/platform/graphics/ImageFrameGenerator.cpp:72: static bool
updateYUVComponentSizes(ImageDecoder* decoder, SkISize componentSizes[3],
ImageDecoder::SizeType sizeType)
On 2014/09/11 19:57:41, sugoi1 wrote:
> Oops, adding the "const" here was causing the isSizeAvailable() call to use
the
> const implementation instead of using the overloaded non const version in
> JPEGImageDecoder, so it was always false.

Ack.

Powered by Google App Engine
This is Rietveld 408576698