Re-enabling YUV GPU decoding

Source/platform/graphics/ImageFrameGenerator.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 51 matching lines @@
         dst->lockPixels();
         return true;
     }
 
 private:
     SkImageInfo m_info;
     void* m_pixels;
     size_t m_rowBytes;
 };
 
-static bool updateYUVComponentSizes(const ImageDecoder* decoder, SkISize componentSizes[3], ImageDecoder::SizeType sizeType)
+static bool updateYUVComponentSizes(ImageDecoder* decoder, SkISize componentSizes[3], ImageDecoder::SizeType sizeType)

[sugoi1, 2014/09/11 19:57:41]

Oops, adding the "const" here was causing the isSizeAvailable() call to use the
const implementation instead of using the overloaded non const version in
JPEGImageDecoder, so it was always false.

[Noel Gordon, 2014/09/12 01:47:06]

Ack.

 {
     // canDecodeToYUV() has to be called AFTER isSizeAvailable(),
     // otherwise the output color space may not be set in the decoder.
     if (!decoder->isSizeAvailable() || !decoder->canDecodeToYUV())
         return false;
 
     IntSize size = decoder->decodedYUVSize(0, sizeType);
     componentSizes[0].set(size.width(), size.height());
     size = decoder->decodedYUVSize(1, sizeType);
     componentSizes[1].set(size.width(), size.height());
@@ skipping 248 matching lines @@
 
     // Setting a dummy ImagePlanes object signals to the decoder that we want to do YUV decoding.
     decoder->setData(data, allDataReceived);
     OwnPtr<ImagePlanes> dummyImagePlanes = adoptPtr(new ImagePlanes);
     decoder->setImagePlanes(dummyImagePlanes.release());
 
     return updateYUVComponentSizes(decoder.get(), componentSizes, ImageDecoder::SizeForMemoryAllocation);
 }
 
 } // namespace blink