Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 544773003: Enable Blink's asserts for release-with-asserts builds. (Closed)

Created:
6 years, 3 months ago by jam
Modified:
6 years, 3 months ago
CC:
abarth-chromium, aandrey+blink_chromium.org, blink-reviews, blink-reviews-wtf_chromium.org, Ken Russell (switch to Gerrit), Mikhail
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Enable Blink's asserts for release-with-asserts builds. We run into issues where a cl lands through Chromium's trybots and then breaks the main waterfall because of this. Chromium's trybots use release-with-asserts builds. BUG=410916 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181425

Patch Set 1 #

Patch Set 2 : widen previous test disables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M LayoutTests/TestExpectations View 1 3 chunks +3 lines, -4 lines 0 comments Download
M Source/wtf/Assertions.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
jam
6 years, 3 months ago (2014-09-04 20:20:19 UTC) #2
dglazkov
lgtm
6 years, 3 months ago (2014-09-04 20:25:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/544773003/1
6 years, 3 months ago (2014-09-04 20:27:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/23512)
6 years, 3 months ago (2014-09-04 22:01:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/544773003/20001
6 years, 3 months ago (2014-09-04 22:21:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 181425
6 years, 3 months ago (2014-09-05 00:29:03 UTC) #10
abarth-chromium
+kbr We how have two ways of doing this. We should remove one of them ...
6 years, 3 months ago (2014-09-06 15:25:13 UTC) #12
abarth-chromium
6 years, 3 months ago (2014-09-06 15:27:04 UTC) #13
Message was sent while issue was closed.
Apparently KBR already noticed:
https://code.google.com/p/chromium/issues/detail?id=411008

Powered by Google App Engine
This is Rietveld 408576698