Source/wtf/Assertions.h - Issue 544773003: Enable Blink's asserts for release-with-asserts builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/wtf/Assertions.h

Issue 544773003: Enable Blink's asserts for release-with-asserts builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: widen previous test disables Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/wtf/Assertions.h

diff --git a/Source/wtf/Assertions.h b/Source/wtf/Assertions.h

index 04eaa6e657b2c4e204f1290604c66442df8326b6..e4bd90feefadca9b650307a91d342b84129f4b59 100644

--- a/Source/wtf/Assertions.h

+++ b/Source/wtf/Assertions.h

@@ -46,12 +46,12 @@

// Users must test "#if ENABLE(ASSERT)", which helps ensure that code

// testing this macro has included this header.

#ifndef ENABLE_ASSERT

-#ifdef NDEBUG

+#if defined(NDEBUG) && !defined(DCHECK_ALWAYS_ON)

/* Disable ASSERT* macros in release mode by default. */

#define ENABLE_ASSERT 0

#else

#define ENABLE_ASSERT 1

-#endif /* NDEBUG */

+#endif /* defined(NDEBUG) && !defined(DCHECK_ALWAYS_ON) */

#endif

#ifndef BACKTRACE_DISABLED

« no previous file with comments | « LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »