Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1064)

Issue 544753003: Move BluetoothEventRouterTest to extensions_unittests suite (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move BluetoothEventRouterTest to extensions_unittests suite The code lives in src/extensions but it was running in Chrome's unit_tests. * Switch to ExtensionsTest * Remove unnecessary UI loop run-until-idle Also fix uninitialized member in TestExtensionsBrowserClient. BUG=397164 TEST=extensions_unittests Bluetooth* Committed: https://crrev.com/7e6b4bb37a4ad4adc534bc3f3e25e70de3a1bbb0 Cr-Commit-Position: refs/heads/master@{#293436}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -26 lines) Patch
M chrome/chrome_tests_unit.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_event_router_unittest.cc View 4 chunks +14 lines, -21 lines 1 comment Download
M extensions/browser/test_extensions_browser_client.cc View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/extensions.gyp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
James Cook
yoz, PTAL https://codereview.chromium.org/544753003/diff/1/extensions/browser/api/bluetooth/bluetooth_event_router_unittest.cc File extensions/browser/api/bluetooth/bluetooth_event_router_unittest.cc (left): https://codereview.chromium.org/544753003/diff/1/extensions/browser/api/bluetooth/bluetooth_event_router_unittest.cc#oldcode57 extensions/browser/api/bluetooth/bluetooth_event_router_unittest.cc:57: run_loop.RunUntilIdle(); This appears unnecessary. I think it ...
6 years, 3 months ago (2014-09-04 18:09:12 UTC) #2
Yoyo Zhou
LGTM
6 years, 3 months ago (2014-09-04 23:25:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/544753003/1
6 years, 3 months ago (2014-09-04 23:57:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 99f93df4c4a338671a399943f3d7a229cf8d5bf2
6 years, 3 months ago (2014-09-05 04:37:30 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:36:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e6b4bb37a4ad4adc534bc3f3e25e70de3a1bbb0
Cr-Commit-Position: refs/heads/master@{#293436}

Powered by Google App Engine
This is Rietveld 408576698