Move BluetoothEventRouterTest to extensions_unittests suite

extensions/browser/api/bluetooth/bluetooth_event_router_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/run_loop.h"
-#include "chrome/browser/extensions/test_extension_system.h"
-#include "chrome/test/base/testing_profile.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/test/test_browser_context.h"
 #include "content/public/test/test_browser_thread.h"
-#include "content/public/test/test_browser_thread_bundle.h"
 #include "device/bluetooth/bluetooth_uuid.h"
 #include "device/bluetooth/test/mock_bluetooth_adapter.h"
-#include "device/bluetooth/test/mock_bluetooth_device.h"
 #include "extensions/browser/api/bluetooth/bluetooth_event_router.h"
-#include "extensions/browser/event_router.h"
 #include "extensions/browser/extension_registry.h"
+#include "extensions/browser/extensions_test.h"
 #include "extensions/common/api/bluetooth.h"
 #include "extensions/common/extension_builder.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace {
 
 const char kTestExtensionId[] = "test extension id";
 const device::BluetoothUUID kAudioProfileUuid("1234");
 const device::BluetoothUUID kHealthProfileUuid("4321");
 
 }  // namespace
 
 namespace extensions {
 
 namespace bluetooth = core_api::bluetooth;
 
-class BluetoothEventRouterTest : public testing::Test {
+class BluetoothEventRouterTest : public ExtensionsTest {
  public:
   BluetoothEventRouterTest()
       : ui_thread_(content::BrowserThread::UI, &message_loop_),
         mock_adapter_(new testing::StrictMock<device::MockBluetoothAdapter>()),
-        test_profile_(new TestingProfile()),
-        router_(new BluetoothEventRouter(test_profile_.get())) {
+        notification_service_(content::NotificationService::Create()),
+        router_(new BluetoothEventRouter(browser_context())) {
     router_->SetAdapterForTest(mock_adapter_);
   }
 
   virtual void TearDown() OVERRIDE {
-    // Some profile-dependent services rely on UI thread to clean up. We make
-    // sure they are properly cleaned up by running the UI message loop until
-    // idle.
-    // It's important to destroy the router before the |test_profile_| so it
-    // removes itself as an observer.
+    // It's important to destroy the router before the browser context keyed
+    // services so it removes itself as an ExtensionRegistry observer.
     router_.reset(NULL);
-    test_profile_.reset(NULL);
-    base::RunLoop run_loop;
-    run_loop.RunUntilIdle();

[James Cook, 2014/09/04 18:09:12]

This appears unnecessary. I think it was there because TestingProfile creates a
bunch of services.

+    ExtensionsTest::TearDown();
   }
 
  protected:
   base::MessageLoopForUI message_loop_;
   // Note: |ui_thread_| must be declared before |router_|.
   content::TestBrowserThread ui_thread_;
   testing::StrictMock<device::MockBluetoothAdapter>* mock_adapter_;
-  scoped_ptr<TestingProfile> test_profile_;
+  scoped_ptr<content::NotificationService> notification_service_;
   scoped_ptr<BluetoothEventRouter> router_;
 };
 
 TEST_F(BluetoothEventRouterTest, BluetoothEventListener) {
   router_->OnListenerAdded();
   EXPECT_CALL(*mock_adapter_, RemoveObserver(testing::_)).Times(1);
   router_->OnListenerRemoved();
 }
 
 TEST_F(BluetoothEventRouterTest, MultipleBluetoothEventListeners) {
   router_->OnListenerAdded();
   router_->OnListenerAdded();
   router_->OnListenerAdded();
   router_->OnListenerRemoved();
   router_->OnListenerRemoved();
   EXPECT_CALL(*mock_adapter_, RemoveObserver(testing::_)).Times(1);
   router_->OnListenerRemoved();
 }
 
 TEST_F(BluetoothEventRouterTest, UnloadExtension) {
-  scoped_refptr<const extensions::Extension> extension =
-      extensions::ExtensionBuilder()
-          .SetManifest(extensions::DictionaryBuilder()
+  scoped_refptr<const Extension> extension =
+      ExtensionBuilder()
+          .SetManifest(DictionaryBuilder()
               .Set("name", "BT event router test")
               .Set("version", "1.0")
               .Set("manifest_version", 2))
           .SetID(kTestExtensionId)
           .Build();
 
-  ExtensionRegistry::Get(test_profile_.get())->TriggerOnUnloaded(
+  ExtensionRegistry::Get(browser_context())->TriggerOnUnloaded(
       extension.get(), UnloadedExtensionInfo::REASON_DISABLE);
 
   EXPECT_CALL(*mock_adapter_, RemoveObserver(testing::_)).Times(1);
 }
 
 }  // namespace extensions