Make js-test-post a noop.

Make js-test-post a noop.

Will delete the file in a followup patch.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161115

[commit-bot: I haz the power, 2013-10-31 19:29:47]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[esprehn, 2013-10-31 19:34:23]

LGTM

[ojan, 2013-10-31 20:19:04]

Ugh. This patch causes flakiness. There's a bunch of tests that call
waitUntilDone, and then do something like the following to notifyDone instead of
using js-test-pre's way of making tests async:

  var epilogue = document.createElement("script")
  epilogue.onload = function() {
    if (window.nonKhronosFrameworkNotifyDone) {
      window.nonKhronosFrameworkNotifyDone();
    }
  };
  epilogue.src = "../../js/resources/js-test-post.js";
  document.body.appendChild(epilogue);

[commit-bot: I haz the power, 2013-10-31 21:28:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ojan@chromium.org/54473004/1950001

[ojan, 2013-10-31 21:28:33]

I changed all the lazy loading js-test-post files to instead set
window.jsTestIsAsync=true and call finishJSTest directly.

[commit-bot: I haz the power, 2013-10-31 22:57:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ojan@chromium.org/54473004/360047

[commit-bot: I haz the power, 2013-10-31 23:16:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ojan@chromium.org/54473004/2000002

[commit-bot: I haz the power, 2013-11-01 00:50:18]

Change committed as 161115

[eae, 2013-11-18 19:36:13]

https://codereview.chromium.org/54473004/diff/2000002/LayoutTests/svg/as-obje...
File LayoutTests/svg/as-object/nested-embedded-svg-size-changes-expected.txt
(right):

https://codereview.chromium.org/54473004/diff/2000002/LayoutTests/svg/as-obje...
LayoutTests/svg/as-object/nested-embedded-svg-size-changes-expected.txt:10: PASS
successfullyParsed is true
We have a bunch of test now that print this multiple times and right in the
middle of the output. Not only does this seem incorrect it is also entirely
pointless. I thought the plan was _remove_ this message and not add more copies
of it. Is that no longer the case or is this still work in progress?

[ojan, 2013-11-18 19:44:11]

On 2013/11/18 19:36:13, eae wrote:
>
https://codereview.chromium.org/54473004/diff/2000002/LayoutTests/svg/as-obje...
> File LayoutTests/svg/as-object/nested-embedded-svg-size-changes-expected.txt
> (right):
> 
>
https://codereview.chromium.org/54473004/diff/2000002/LayoutTests/svg/as-obje...
> LayoutTests/svg/as-object/nested-embedded-svg-size-changes-expected.txt:10:
PASS
> successfullyParsed is true
> We have a bunch of test now that print this multiple times and right in the
> middle of the output. Not only does this seem incorrect it is also entirely
> pointless. I thought the plan was _remove_ this message and not add more
copies
> of it. Is that no longer the case or is this still work in progress?

My plan was to get rid of the successfullyParsed line. Everyone agrees that it
serves no purpose now. It's just the work of getting rid of it and updated all
the expected results. Some people expressed liking the TEST COMPLETE line. I
don't personally feel strongly either way, but I've lost steam on the project
and won't be doing this anytime soon.

[eae, 2013-11-18 19:45:13]

Ok, I might tackle it then as I really dislike it.

On Mon, Nov 18, 2013 at 11:44 AM,  <ojan@chromium.org> wrote:
> On 2013/11/18 19:36:13, eae wrote:
>
>
https://codereview.chromium.org/54473004/diff/2000002/LayoutTests/svg/as-obje...
>>
>> File
>> LayoutTests/svg/as-object/nested-embedded-svg-size-changes-expected.txt
>> (right):
>
>
>
>
https://codereview.chromium.org/54473004/diff/2000002/LayoutTests/svg/as-obje...
>>
>>
>> LayoutTests/svg/as-object/nested-embedded-svg-size-changes-expected.txt:10:
>
> PASS
>>
>> successfullyParsed is true
>> We have a bunch of test now that print this multiple times and right in
>> the
>> middle of the output. Not only does this seem incorrect it is also
>> entirely
>> pointless. I thought the plan was _remove_ this message and not add more
>
> copies
>>
>> of it. Is that no longer the case or is this still work in progress?
>
>
> My plan was to get rid of the successfullyParsed line. Everyone agrees that
> it
> serves no purpose now. It's just the work of getting rid of it and updated
> all
> the expected results. Some people expressed liking the TEST COMPLETE line. I
> don't personally feel strongly either way, but I've lost steam on the
> project
> and won't be doing this anytime soon.
>
> https://codereview.chromium.org/54473004/

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.